From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14BAFC433F5 for ; Fri, 29 Oct 2021 18:39:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAAD261037 for ; Fri, 29 Oct 2021 18:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbhJ2Sm0 (ORCPT ); Fri, 29 Oct 2021 14:42:26 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:45811 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbhJ2SmX (ORCPT ); Fri, 29 Oct 2021 14:42:23 -0400 Received: by mail-ot1-f53.google.com with SMTP id l16-20020a9d6a90000000b0054e7ab56f27so14764895otq.12; Fri, 29 Oct 2021 11:39:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZbJJ3sirvGO1Q5qzFIR+Qcm5nvITBleUPONekunq9do=; b=FPP9oLtujVqmUWWVn8s4bQ+1chwHt7/d0CuFHFKZVC5ldkNpNcWrn4CYL4hUK5liJx KAo7IYHTdqQXnPjZUlRei26k2+PfDTokieFRl2OhHTNxAmKD+EP+JuXb1UiehJjOkqWg te8hK0Y31PAYGUSXexM4JhA3EgV8xM62gGqU9gC76V5bpUuxeLEe9NTksnuIoOu5Dr89 /GyxAl8+k9wjJSBMK8mOXf690txd44+aymZgXMBTD82V7VzHdcLAtsr9laSmrYm+05Jh 1k8KMQbVu7xUOcAKgG/ZzSd5Jjy9gIqlzULStbtQkHmqAuZ9UAzrGZrLiJ657epbOg6k wezg== X-Gm-Message-State: AOAM532Nmr2c+jWUkD0DNzsdfR6s4OnxCGIh6fCwlVvv/6/9ieyO3Rop CQTdw/W8sGJx3cLTlEYm61UChq2Vfnc+BjdcpaU= X-Google-Smtp-Source: ABdhPJzzT6cB8eCDJmpVcRiVJH/HJQE931S3wWY6YLrIMln0JVWc33duNyd4uacmLGMUV1B0MfAnmK1v5Cm4HHKIGks= X-Received: by 2002:a05:6830:90b:: with SMTP id v11mr9843423ott.254.1635532794570; Fri, 29 Oct 2021 11:39:54 -0700 (PDT) MIME-Version: 1.0 References: <20211018202542.584115-1-tony.luck@intel.com> <20211026220050.697075-1-tony.luck@intel.com> <20211026220050.697075-8-tony.luck@intel.com> In-Reply-To: <20211026220050.697075-8-tony.luck@intel.com> From: "Rafael J. Wysocki" Date: Fri, 29 Oct 2021 20:39:43 +0200 Message-ID: Subject: Re: [PATCH v11 7/7] x86/sgx: Add check for SGX pages to ghes_do_memory_failure() To: Tony Luck Cc: Borislav Petkov , "the arch/x86 maintainers" , "Rafael J. Wysocki" , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Andrew Morton , Sean Christopherson , Jarkko Sakkinen , Dave Hansen , Cathy Zhang , linux-sgx@vger.kernel.org, ACPI Devel Maling List , Linux Memory Management List , Linux Kernel Mailing List , Reinette Chatre Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 27, 2021 at 12:01 AM Tony Luck wrote: > > SGX EPC pages do not have a "struct page" associated with them so the > pfn_valid() sanity check fails and results in a warning message to > the console. > > Add an additional check to skip the warning if the address of the error > is in an SGX EPC page. > > Reviewed-by: Jarkko Sakkinen > Tested-by: Reinette Chatre > Signed-off-by: Tony Luck Acked-by: Rafael J. Wysocki > --- > drivers/acpi/apei/ghes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 0c8330ed1ffd..0c5c9acc6254 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -449,7 +449,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags) > return false; > > pfn = PHYS_PFN(physical_addr); > - if (!pfn_valid(pfn)) { > + if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) { > pr_warn_ratelimited(FW_WARN GHES_PFX > "Invalid address in generic error data: %#llx\n", > physical_addr); > -- > 2.31.1 >