From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Won Chung <wonchung@google.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Benson Leung <bleung@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] ACPI: device_sysfs: Add sysfs support for _PLD
Date: Mon, 14 Feb 2022 20:11:53 +0100 [thread overview]
Message-ID: <CAJZ5v0gD4zs3uBAYv6M4_1gNpkZ-g9XKOywJnf5007e6GwoGVA@mail.gmail.com> (raw)
In-Reply-To: <20220211023008.3197397-1-wonchung@google.com>
On Fri, Feb 11, 2022 at 3:30 AM Won Chung <wonchung@google.com> wrote:
>
> When ACPI table includes _PLD fields for a device, create a new
> directory (pld) in sysfs to share _PLD fields.
This version of the patch loos better to me, but I'm not sure if it
goes into the right direction overall.
> Currently without PLD information, when there are multiple of same
> devices, it is hard to distinguish which device corresponds to which
> physical device in which location. For example, when there are two Type
> C connectors, it is hard to find out which connector corresponds to the
> Type C port on the left panel versus the Type C port on the right panel.
So I think that this is your primary use case and I'm wondering if
this is the best way to address it.
Namely, by exposing _PLD information under the ACPI device object,
you'll make user space wanting to use that information depend on this
interface, but the problem is not ACPI-specific (inevitably, it will
appear on systems using DT, sooner or later) and making the user space
interface related to it depend on ACPI doesn't look like a perfect
choice.
IOW, why don't you create a proper ABI for this in the Type C
subsystem and expose the information needed by user space in a generic
way that can be based on the _PLD information on systems with ACPI?
next prev parent reply other threads:[~2022-02-14 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 2:30 [PATCH v6] ACPI: device_sysfs: Add sysfs support for _PLD Won Chung
2022-02-14 19:11 ` Rafael J. Wysocki [this message]
2022-02-14 20:30 ` Won Chung
2022-02-14 22:58 ` Won Chung
2022-02-15 10:14 ` Heikki Krogerus
2022-02-15 13:54 ` Rafael J. Wysocki
2022-02-16 11:34 ` Heikki Krogerus
2022-02-16 16:39 ` Rafael J. Wysocki
2022-02-18 1:15 ` Won Chung
2022-02-18 17:24 ` Rafael J. Wysocki
2022-02-18 19:48 ` Won Chung
2022-02-28 19:12 ` Won Chung
2022-02-15 14:04 ` Rafael J. Wysocki
2022-02-15 14:08 ` Rafael J. Wysocki
2022-02-16 17:33 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gD4zs3uBAYv6M4_1gNpkZ-g9XKOywJnf5007e6GwoGVA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=bleung@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=wonchung@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).