From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Li,Rongqing" <lirongqing@baidu.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/2][v2] cpuidle-haltpoll: Build as module by default
Date: Thu, 8 Dec 2022 12:42:51 +0100 [thread overview]
Message-ID: <CAJZ5v0gXSUdFeHajUcjV-eh3eW1aRoJ8Yvp9J95czQg0cMetTA@mail.gmail.com> (raw)
In-Reply-To: <17a6782c79a44aada31246ddefe02bfb@baidu.com>
On Thu, Dec 8, 2022 at 3:32 AM Li,Rongqing <lirongqing@baidu.com> wrote:
>
>
> > > Allow user to unload it in running
> >
> > Just like that? And corrupt things left and right while at it?
> >
> > No way.
> >
> > And why do you need this?
>
> Cpuidle-haltpoll can not improve performance for all cases, like when guest has mwait, unixbench shows a small performance drop;
> So change it as module, user can insmod this drivers and rmmod this driver at run time
That is problematic, because in the mainline Linux kernel (which is
what we are talking about here) there is no support for modular
cpuidle governors.
Also, there is an interface for switching cpuidle governors at run
time already, so why can 't it be used to address this case?
> And some downstream os, centos and ubuntu build it module
Well, it's their problem.
next prev parent reply other threads:[~2022-12-08 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 12:41 [PATCH 1/2][v2] cpuidle-haltpoll: Replace default_idle with arch_cpu_idle lirongqing
2022-12-07 12:41 ` [PATCH 2/2][v2] cpuidle-haltpoll: Build as module by default lirongqing
2022-12-07 14:39 ` Rafael J. Wysocki
[not found] ` <080936016634.CAJZ5v0i9J2YimfQsqJiZjFMR9MLG0fdBf+Regr+_PcsYrAE=SQ@mail.gmail.com>
2022-12-08 2:32 ` Li,Rongqing
2022-12-08 11:42 ` Rafael J. Wysocki [this message]
2022-12-08 12:42 ` Li,Rongqing
2022-12-08 13:11 ` Rafael J. Wysocki
2022-12-16 15:01 ` Peter Zijlstra
2022-12-07 14:37 ` [PATCH 1/2][v2] cpuidle-haltpoll: Replace default_idle with arch_cpu_idle Rafael J. Wysocki
[not found] ` <080936167059.CAJZ5v0g5kTRE+x-8xC2WwQr11j01ox=Nk0aguiC1_HGPU8W=Rw@mail.gmail.com>
2022-12-08 1:46 ` Li,Rongqing
2022-12-08 11:39 ` Rafael J. Wysocki
2022-12-08 12:41 ` Li,Rongqing
2022-12-08 13:01 ` Rafael J. Wysocki
2022-12-09 13:44 ` Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gXSUdFeHajUcjV-eh3eW1aRoJ8Yvp9J95czQg0cMetTA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=daniel.lezcano@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).