From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5161C4320E for ; Fri, 30 Jul 2021 12:13:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB7C660EE6 for ; Fri, 30 Jul 2021 12:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238755AbhG3MN3 (ORCPT ); Fri, 30 Jul 2021 08:13:29 -0400 Received: from mail-oi1-f179.google.com ([209.85.167.179]:36815 "EHLO mail-oi1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230355AbhG3MN1 (ORCPT ); Fri, 30 Jul 2021 08:13:27 -0400 Received: by mail-oi1-f179.google.com with SMTP id y18so12921321oiv.3; Fri, 30 Jul 2021 05:13:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h/nWd7/gRGV1qmwqjSQqAFbq0T5N0Ue6f9xRmUkU8nE=; b=fBbJsZ2AERbldlv6Oni+QBQNC30lXFlL8WtLXR77069BvNv6//2Wg1hNFNUbjDOndv n15pOBidjrH96JR5JpIWrkqsLkATa8tuA4kaq258ZDn68bVjbmdE81BaDVMGX8aUhcTo YfSbfru4rYiG92d/ty5nZEh5U4F1em3pBXyKb/1PK5qhYWRa9SXtVYEdCd7UEDIQHIEG XPy8gBZTA5crfskNTPys8hpScLAht0ZAC8mspm4ygY0xAJBJk5Z4RoFcNgYm2/5AVsLt pI6tMSZgFrKLaWU9naBBhqcfC/u4/CGgm++CQKCO2DR/6knMqGGYu4Vm4vv6vQu8dhwO fEMA== X-Gm-Message-State: AOAM532wWdg6BUIAxYRIhjA2KhLtVKeSUhAwdTQLj9HZHDbFkdiQrQ8g U8akIqgGI+YaWymXig+V6ANQ9ndOqMHzn9n6p68= X-Google-Smtp-Source: ABdhPJz45M3knNhHMrzCYlaLNNR4m0GdsnXb7oHj0LtftPm2N3HMDgTHqU060pmcerIRLKGkOElBDfIUzpjvPVPoojY= X-Received: by 2002:a05:6808:198c:: with SMTP id bj12mr1556667oib.71.1627647201379; Fri, 30 Jul 2021 05:13:21 -0700 (PDT) MIME-Version: 1.0 References: <4668274.31r3eYUQgx@kreacher> <1791325.tdWV9SEqCh@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Fri, 30 Jul 2021 14:13:09 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] PCI: PM: Enable PME if it can be signaled from D3cold To: Mika Westerberg Cc: "Rafael J. Wysocki" , Linux PCI , Linux ACPI , Linux PM , LKML , Bjorn Helgaas , Kai-Heng Feng , Utkarsh H Patel , Koba Ko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 12:28 PM Mika Westerberg wrote: > > On Thu, Jul 29, 2021 at 04:49:10PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > PME signaling is only enabled by __pci_enable_wake() if the target > > device can signal PME from the given target power state (to avoid > > pointless reconfiguration of the device), but if the hierarchy above > > the device goes into D3cold, the device itself will end up in D3cold > > too, so if it can signal PME from D3cold, it should be enabled to > > do so in __pci_enable_wake(). > > > > [Note that if the device does not end up in D3cold and it cannot > > signal PME from the original target power state, it will not signal > > PME, so in that case the behavior does not change.] > > > > Link: https://lore.kernel.org/linux-pm/3149540.aeNJFYEL58@kreacher/ > > Fixes: 5bcc2fb4e815 ("PCI PM: Simplify PCI wake-up code") > > Reported-by: Mika Westerberg > > Reviewed-by: Mika Westerberg > > Also this solves the reported issue so, > > Tested-by: Mika Westerberg Thank you! I'll queue up these two patches for 5.15 barring any objections from Bjorn.