From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCAFC2D0C9 for ; Fri, 13 Dec 2019 08:37:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12B24206B7 for ; Fri, 13 Dec 2019 08:37:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576226266; bh=hrUtcMROVbSj3bFQMrJtvcxKtecQ0YYWZGQ6UFEvpuE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=al15miIHEp+4YNIIVJUFE0xz4ByrOpNED1rCq+oYB/zF+KlESgukkWP4lDV/5NPZf uiE4di1zvsgLxgo2Nh39/o9rzeSDrrf+5kIamzg+wGxWVjTfglxhFj5NbBfiS7DNTv aW8cguBugKmqIjqOGuePiixaLDOB/pdWpW2+2wr8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbfLMIhp (ORCPT ); Fri, 13 Dec 2019 03:37:45 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:39206 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfLMIhn (ORCPT ); Fri, 13 Dec 2019 03:37:43 -0500 Received: by mail-ot1-f67.google.com with SMTP id 77so5492241oty.6; Fri, 13 Dec 2019 00:37:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hrUtcMROVbSj3bFQMrJtvcxKtecQ0YYWZGQ6UFEvpuE=; b=H6lumRRZfMia/fXBlvj0yzat0cyD68UyCiANSvczQJxLyOq6oAfOgLap1jr9Tn2tsn 7TDLX5aWebiv9J3cfR3UZIOxiwzAEh/eCHW0KflOTdV3kXgIk88ehdvTCDru07C6498n 3eAPRFv1XtTf8oIU+ohratFwAKEB3L7RVXvUs1AOSGpUwZaWPdpCj6f6DLlqTbfVtah2 +2tTSGUcnETLd4fwfAgMg1sbheSd0wUpwj0MU9pfUKPtlndiuuHnS5Ko9OwgGBYus0H5 ryOVoXRAsqf75liyAIK4E8qBsZj9G178YYRl0gEWTKcCR7u7g0TYN9/WlU0jLQx/lCjF idxg== X-Gm-Message-State: APjAAAV6QgQ3Sd8dH+lBVpVOcnplffXI+YMLKgyqvSjNReQSo5EwpYxF 8RLDFGmIqqpzeFCC4LAG03vr8JTVIHGDe6YsIzM= X-Google-Smtp-Source: APXvYqzwQuxqpAXr1PaoHa2ITEuOSiCxR6CYI4S0X2/CUhtNPf5jZ7bP1wxtc/TXNOR61beC6esoVnZKEDS8l3BlkTs= X-Received: by 2002:a05:6830:18cd:: with SMTP id v13mr12830287ote.118.1576226262292; Fri, 13 Dec 2019 00:37:42 -0800 (PST) MIME-Version: 1.0 References: <20191108042225.45391-1-dmitry.torokhov@gmail.com> <20191108042225.45391-2-dmitry.torokhov@gmail.com> <20191212112825.GK32742@smile.fi.intel.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Fri, 13 Dec 2019 09:37:31 +0100 Message-ID: Subject: Re: [PATCH v8 1/6] software node: rename is_array to is_inline To: Marek Szyprowski Cc: "Rafael J. Wysocki" , Andy Shevchenko , Dmitry Torokhov , Heikki Krogerus , Mika Westerberg , Linus Walleij , Ard Biesheuvel , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver , Linux Samsung SOC , Krzysztof Kozlowski , Felipe Balbi , Linux USB Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 13, 2019 at 7:47 AM Marek Szyprowski wrote: > > Hi Rafael, > > On 12.12.2019 17:41, Rafael J. Wysocki wrote: > > On Thu, Dec 12, 2019 at 12:28 PM Andy Shevchenko > > wrote: > >> On Thu, Dec 12, 2019 at 12:12:36PM +0100, Marek Szyprowski wrote: > >>> On 08.11.2019 05:22, Dmitry Torokhov wrote: > >>>> We do not need a special flag to know if we are dealing with an array, > >>>> as we can get that data from ratio between element length and the data > >>>> size, however we do need a flag to know whether the data is stored > >>>> directly inside property_entry or separately. > >>>> > >>>> Signed-off-by: Dmitry Torokhov > >>> Today I've noticed that this patch got merged to linux-next as commit > >>> e6bff4665c595b5a4aff173848851ed49ac3bfad. Sadly it breaks DWC3/xHCI > >>> driver operation on Samsung Exynos5 SoCs (and probably on other SoCs > >>> which use DWC3 in host mode too). I get the following errors during boot: > >>> > >>> dwc3 12000000.dwc3: failed to add properties to xHCI > >>> dwc3 12000000.dwc3: failed to initialize host > >>> dwc3: probe of 12000000.dwc3 failed with error -61 > >>> > >>> Here is a full kernel log from Exynos5250-based Snow Chromebook on KernelCI: > >>> > >>> https://storage.kernelci.org/next/master/next-20191212/arm/exynos_defconfig/gcc-8/lab-collabora/boot-exynos5250-snow.txt > >>> > >>> (lack of 'ref' clk is not related nor fatal to the driver operation). > >>> > >>> The code which fails after this patch is located in > >>> drivers/usb/dwc3/host.c. Let me know if I can help more in locating the bug. > >> Thank you for report. > >> > >> I think we should not have that patch in the fist place... I used to have > >> a bad feeling about it and then forgot about it existence. > > Well, I think you mean the [2/6]. > > > > The $subject one really shouldn't change functionality, we must have > > missed something here. > > Nope, I was really talking about [1/6]. It looks that it revealed an > issue in the DWC3 driver pointed by Dmitry. Right, but I was referring to the Andy's comment. Cheers!