From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D9DBC433E0 for ; Fri, 31 Jul 2020 11:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF25522B40 for ; Fri, 31 Jul 2020 11:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596195220; bh=nRMU61Aikd6d7OiSdk8nqrvF5kYZ8WTzMhfKjj86UAQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=eLZDniK86PtaqSZ7nMytix90tml155gBEp4dOu3TtK+cRlZ905Zdg840QhHrrbxEL axmo8MC2XNTokz1DxYnqy1UNjTY1LXSQPiDMloDnxDV9xOLjIL2nxJFbLDX1AJ6sYt IpJyvTwwP9XlNr8c0x1TVeRK6hz64NhBe0jzHWmw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732746AbgGaLdj (ORCPT ); Fri, 31 Jul 2020 07:33:39 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:40075 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732104AbgGaLdi (ORCPT ); Fri, 31 Jul 2020 07:33:38 -0400 Received: by mail-oi1-f195.google.com with SMTP id u24so16553690oiv.7; Fri, 31 Jul 2020 04:33:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mpZwL9ptFKxq7FoZCH1xjumTWQNcssejfeTwP6RoxpQ=; b=diuHMLwFGE03iB6FycWL3gzVKV7vJzuDP40K9hGRPOQcLzQIi9LpAbE+bb+iu1Zva7 b7hj6RtcnDvzlg7h3eYbSZvJLmYlNeNiRCKL900jpKHwv5KXYbY7L3g/VaYc1GjEyoJz EE8UibbNHAQ2xvP8l3MH4L5l0FT4XlCfQzCJza6pD2tBjS5oTSksRX8gkBKX5BTHbyAj SNrwrRNcYA3QhnfE9ylEFohlC84WnJz2erwTT4CWf6vKCMDutiNwj6fk+z3+F0SBtbNO EugJdjKvoeNHJYWBqakqrimVl0NheHFYPhWy6JR2X2uYm3YS8xkhOyZaGfRIrMZeD5Ah eHbA== X-Gm-Message-State: AOAM530dUNDrNfQUhFqddHrZ4wxeJDT4smiaX9qYbSJjy0kPyRTht2Sh oStEZMDE27hETN8WPbTTQSjTqHdUHemGtOqXmik= X-Google-Smtp-Source: ABdhPJwjnTZ4vCcK+PJMw9f0cgXjEhaXp88nRbYUPJxc2xho6yL2W9vIsfi0PJ+loYFbKG0KfjHoOo6H/h7XzI4Nqoc= X-Received: by 2002:aca:a88e:: with SMTP id r136mr2704600oie.110.1596195217368; Fri, 31 Jul 2020 04:33:37 -0700 (PDT) MIME-Version: 1.0 References: <1596166744-2954-1-git-send-email-neal.liu@mediatek.com> <1596166744-2954-2-git-send-email-neal.liu@mediatek.com> In-Reply-To: <1596166744-2954-2-git-send-email-neal.liu@mediatek.com> From: "Rafael J. Wysocki" Date: Fri, 31 Jul 2020 13:33:24 +0200 Message-ID: Subject: Re: [PATCH] acpi: fix 'return' with no value build warning To: Neal Liu Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thierry Reding , Jonathan Hunter , Jacob Pan , Matthias Brugger , Sami Tolvanen , ACPI Devel Maling List , Linux PM , linux-tegra , Linux ARM , "moderated list:ARM/Mediatek SoC..." , lkml , wsd_upstream Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 31, 2020 at 5:39 AM Neal Liu wrote: > > Fixing CFI issue which introduced by commit efe9711214e6 is > incomplete. > Add return value to fix return-type build warning. > > Signed-off-by: Neal Liu Applied with edited subject and changelog, but -> > --- > drivers/acpi/processor_idle.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index 6ffb6c9..6870020 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -664,11 +664,11 @@ static int acpi_idle_enter_s2idle(struct cpuidle_device *dev, > struct acpi_processor *pr = __this_cpu_read(processors); > > if (unlikely(!pr)) > - return; > + return -EFAULT; -> there is no point returning an error code here, so I've made it just return 0. > > if (pr->flags.bm_check) { > acpi_idle_enter_bm(pr, cx, false); > - return; > + return 0; > } else { > ACPI_FLUSH_CPU_CACHE(); > } > --