From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Bastien Nocera" <hadess@hadess.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Jiri Kosina" <jikos@kernel.org>,
"Filipe Laíns" <lains@riseup.net>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Thorsten Leemhuis" <regressions@leemhuis.info>
Subject: Re: [PATCH v1 2/2] HID: logitech-hidpp: Add Bluetooth Mouse M336/M337/M535 to unhandled_hidpp_devices[]
Date: Wed, 7 Dec 2022 11:11:32 +0100 [thread overview]
Message-ID: <CAJZ5v0gwBUBbGLoW4xZCEOnGRdi-8gKNDgQ6KJEebLyxyJEUkg@mail.gmail.com> (raw)
In-Reply-To: <CAO-hwJL7n7HFk4MTKvLcvBPSLDwm9pHqLaZvmuwvSNDVWUF76g@mail.gmail.com>
On Wed, Dec 7, 2022 at 11:05 AM Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> On Wed, Dec 7, 2022 at 10:47 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Wed, Dec 7, 2022 at 10:29 AM Bastien Nocera <hadess@hadess.net> wrote:
> > >
> > > On Wed, 2022-12-07 at 10:12 +0100, Rafael J. Wysocki wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > >
> > > > Evidently, Logitech Bluetooth Mouse M336/M337/M535 (0xb016) does not
> > > > work when HID++ is enabled for it,
> > >
> > > This needs the output of the hidpp-list-features tool mentioned earlier
> > > in the thread so we can avoid words like "evidently" and provide
> > > concrete proof.
> >
> > Well, so point me to a binary of this, please.
> >
> > > But why is it needed in this case?
> >
> > Because it doesn't work otherwise.
> >
> > > We purposefully try to avoid blanket
> > > blocklists. The lack of HID++ can be probed, so the device should work
> > > just as it used to (if the fallback code works).
> >
> > No, because the hid-generic driver has no way to check that the probe
> > function of your driver fails for this particular device. The probing
> > of hid-generic will fail so long as the device matches the device ID
> > list of any specific HID driver. With patch [1/2] from this series
> > applied this is unless that specific driver has a ->match() callback
> > rejecting the given device.
> >
> > You'd need a list of drivers that have been tried and failed somewhere
> > for that and AFAICS no such list is present in the code.
>
> That is the reason why I never wanted to enable HID++ on all Logitech
> mice, and this comes back to bite us at the worst time possible, right
> before the merge window opens :(
>
> >
> > So a minimum fix for 6.1 that actually works for me is to add the
> > non-working device to the blocklist. More sophisticated stuff can be
> > done later.
>
> Agree, but OTOH, Rafael, your mouse is not brand new AFAICT, so I am
> worried that you won't be the only one complaining we just killed
> their mouse.
> So I think the even wiser solution would be to delay (and so revert in
> 6.1 or 6.2) the 2 patches that enable hid++ on all logitech mice
> (8544c812e43ab7bdf40458411b83987b8cba924d and
> 532223c8ac57605a10e46dc0ab23dcf01c9acb43).
Obviously that would work for me too, so it's your call.
Thanks!
next prev parent reply other threads:[~2022-12-07 10:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 14:58 [Regression] Logitech BT mouse unusable after commit 532223c8ac57 (still in 6.1-rc8) Rafael J. Wysocki
2022-12-07 8:58 ` Rafael J. Wysocki
2022-12-07 9:07 ` Bastien Nocera
2022-12-07 9:04 ` Bastien Nocera
2022-12-07 9:16 ` Rafael J. Wysocki
2022-12-07 9:36 ` Rafael J. Wysocki
2022-12-07 9:58 ` Bastien Nocera
2022-12-07 10:07 ` Rafael J. Wysocki
2022-12-07 10:50 ` Bastien Nocera
2022-12-07 11:07 ` Rafael J. Wysocki
2022-12-07 17:19 ` Bastien Nocera
2022-12-07 17:44 ` Rafael J. Wysocki
2022-12-08 15:20 ` Bastien Nocera
2022-12-13 16:14 ` Bastien Nocera
2022-12-15 15:09 ` Rafael J. Wysocki
2022-12-07 9:10 ` [PATCH v1 0/2] HID: Fix regression resulting from commit 532223c8ac57 Rafael J. Wysocki
2022-12-07 9:11 ` [PATCH v1 1/2] HID: generic: Add ->match() check to __check_hid_generic() Rafael J. Wysocki
2022-12-07 9:27 ` Benjamin Tissoires
2022-12-07 9:54 ` Rafael J. Wysocki
2022-12-07 9:12 ` [PATCH v1 2/2] HID: logitech-hidpp: Add Bluetooth Mouse M336/M337/M535 to unhandled_hidpp_devices[] Rafael J. Wysocki
2022-12-07 9:29 ` Bastien Nocera
2022-12-07 9:47 ` Rafael J. Wysocki
2022-12-07 9:59 ` Bastien Nocera
2022-12-07 10:05 ` Benjamin Tissoires
2022-12-07 10:11 ` Rafael J. Wysocki [this message]
2022-12-07 10:19 ` Jiri Kosina
2022-12-07 12:43 ` Bastien Nocera
2022-12-07 13:00 ` Rafael J. Wysocki
2022-12-07 13:24 ` Benjamin Tissoires
2022-12-07 13:39 ` Rafael J. Wysocki
2022-12-07 14:24 ` Bastien Nocera
2022-12-08 13:32 ` Benjamin Tissoires
2022-12-07 9:48 ` Benjamin Tissoires
2022-12-07 9:59 ` Bastien Nocera
2022-12-08 7:03 ` [Regression] Logitech BT mouse unusable after commit 532223c8ac57 (still in 6.1-rc8) #forregzbot Thorsten Leemhuis
2022-12-09 6:34 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gwBUBbGLoW4xZCEOnGRdi-8gKNDgQ6KJEebLyxyJEUkg@mail.gmail.com \
--to=rafael@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).