From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069D5C433F5 for ; Tue, 17 May 2022 19:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352865AbiEQTlb (ORCPT ); Tue, 17 May 2022 15:41:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352853AbiEQTlE (ORCPT ); Tue, 17 May 2022 15:41:04 -0400 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CDDE1D317; Tue, 17 May 2022 12:41:03 -0700 (PDT) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2ef5380669cso1810917b3.9; Tue, 17 May 2022 12:41:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jA+ZZ535mW9lkveex/k/BNBtXLLURKxBnX7kfn3Gewg=; b=oF1guhNrPBsF9TeKexacQWWMM7lgyzQXxgX/Ehysj0hdK0X2jMp88v7PjSKQYsZGAp DhTBZpMnGUKp8XpWYeLjiHk8uIfhPQ5Aguu0CbBJlT9svNOl5pSQuHpKAGdyNC9EKkXE HbYB2isKJkdyqAwZtJj+YCSnk1OLMOrBqFHF1eJO6g9pOx8s83SL7AfZsRclygCdknL6 7w8+gFvGD3V7ExlWD4AjLzDsdXttMoa+uAHgGNrhVq2YC7l8/WNSmQBnUhozJ7ttSdYw dxAJXVBvpybOtd3eH4+i4vcMsaiKL+9HoMK2A5PbaLPTx4fEnygUiUSWjdpNGYERg5tO Zv3Q== X-Gm-Message-State: AOAM533rmzBem1ghiK6vBvUfFUwUzh5Z8RpbGYrQ2iExHK3PG3xXlEz1 r4j2VeeA90YC5vxj6e2rfEUWrYH8ZFaqLRp6vKI= X-Google-Smtp-Source: ABdhPJzXrvE9IpiiD2ZV48IvdHIaUJPb9W/rDCWV4FPmB+OWzA3lnnkB24Bh7kEgg7Y7If3dUf60H1mV3gFva2yD2vE= X-Received: by 2002:a81:1b97:0:b0:2db:640f:49d8 with SMTP id b145-20020a811b97000000b002db640f49d8mr26970283ywb.326.1652816462836; Tue, 17 May 2022 12:41:02 -0700 (PDT) MIME-Version: 1.0 References: <20220516030251.42323-1-schspa@gmail.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 17 May 2022 21:40:51 +0200 Message-ID: Subject: Re: [PATCH v6 1/2] cpufreq: Abort show/store for half initialized policy To: Viresh Kumar , Schspa Shi Cc: "Rafael J. Wysocki" , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2022 at 12:25 PM Viresh Kumar wrote: > > On Mon, 16 May 2022 at 04:03, Schspa Shi wrote: > > > > If policy initialization fails after the sysfs files are created, > > there is a possibility that we may end up running show()/store() > > callbacks for half initialized policies, which may have unpredictable > > outcomes. > > > > Abort show/store in such a case by making sure the policy is active. > > Also inactivate the policy on such failures. > > > > Signed-off-by: Schspa Shi > > Acked-by: Viresh Kumar Applied along with the [2/2], with some adjustments in the subject and changelog, as 5.19 material. Thanks!