From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752143AbdATKVg (ORCPT ); Fri, 20 Jan 2017 05:21:36 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33708 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbdATKV2 (ORCPT ); Fri, 20 Jan 2017 05:21:28 -0500 MIME-Version: 1.0 In-Reply-To: <20170120075239.GC21013@b29397-desktop> References: <1483596119-27508-1-git-send-email-peter.chen@nxp.com> <1483596119-27508-3-git-send-email-peter.chen@nxp.com> <20170107085456.w5dhm7qadqa6tc7v@kozik-lap> <20170110070240.GA29454@b29397-desktop> <20170120075239.GC21013@b29397-desktop> From: "Rafael J. Wysocki" Date: Fri, 20 Jan 2017 11:21:27 +0100 X-Google-Sender-Auth: 6FI9vfM4E7DAhcvkubpkFGS5Plk Message-ID: Subject: Re: [PATCH v11 2/8] power: add power sequence library To: Peter Chen Cc: "Rafael J. Wysocki" , Peter Chen , Mark Rutland , Ulf Hansson , Heiko Stuebner , Stephen Boyd , Linux Kernel Mailing List , Gary Bisson , Fabio Estevam , Joshua Clayton , Arnd Bergmann , Dmitry Eremin-Solenikov , Vaibhav Hiremath , mka@chromium.org, Alan Stern , "devicetree@vger.kernel.org" , mail@maciej.szmigiero.name, Pawel Moll , Linux PM , Sascha Hauer , troy.kisky@boundarydevices.com, Rob Herring , "linux-arm-kernel@lists.infradead.org" , hverkuil@xs4all.nl, oscar@naiandei.net, Greg Kroah-Hartman , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" , Sebastian Reichel , Mark Brown , p.zabel@pengutronix.de, Shawn Guo , Krzysztof Kozlowski Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 8:52 AM, Peter Chen wrote: > On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote: >> On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote: >> > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote: >> > > We have an well-known problem that the device needs to do some power >> > > sequence before it can be recognized by related host, the typical >> > > example like hard-wired mmc devices and usb devices. >> > > >> > > This power sequence is hard to be described at device tree and handled by >> > > related host driver, so we have created a common power sequence >> > > library to cover this requirement. The core code has supplied >> > > some common helpers for host driver, and individual power sequence >> > > libraries handle kinds of power sequence for devices. The pwrseq >> > > librares always need to allocate extra instance for compatible >> > > string match. >> > > >> > > pwrseq_generic is intended for general purpose of power sequence, which >> > > handles gpios and clocks currently, and can cover other controls in >> > > future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off >> > > if only one power sequence is needed, else call of_pwrseq_on_list >> > > /of_pwrseq_off_list instead (eg, USB hub driver). >> > > >> > > For new power sequence library, it can add its compatible string >> > > to pwrseq_of_match_table, then the pwrseq core will match it with >> > > DT's, and choose this library at runtime. >> > > >> > > Signed-off-by: Peter Chen >> > > Tested-by: Maciej S. Szmigiero >> > > Tested-by Joshua Clayton >> > > Reviewed-by: Matthias Kaehlcke >> > > Tested-by: Matthias Kaehlcke >> > >> > Acked-by: Krzysztof Kozlowski >> > Tested on Odroid U3 (reset sequence for LAN9730): >> > Tested-by: Krzysztof Kozlowski >> > >> >> A nice ping... >> > > Rafael, would you please review it? This series was discussed about > half a year, and many people need it, I hope it can be in v4.11-rc1, > thanks. I'm travelling now (http://marc.info/?l=linux-pm&m=148410629024194&w=2) and (as stated in this message) I'll get to the patches when I'm back home. There is a good chance for your code to go into 4.11-rc1 if the review comments so far have been addressed. Thanks, Rafael