From: "Rafael J. Wysocki" <rafael@kernel.org>
To: jeff.mcgee@intel.com
Cc: isg-gms@eclists.intel.com,
Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/15] acpi: Export acpi_bus_type
Date: Wed, 31 Aug 2016 00:47:39 +0200 [thread overview]
Message-ID: <CAJZ5v0h92aJ_tc+-07-kaU-HYO+Q4U28Ly2kXYJi8vr9A-VXOQ@mail.gmail.com> (raw)
In-Reply-To: <20160830164910.1248-11-jeff.mcgee@intel.com>
On Tue, Aug 30, 2016 at 6:49 PM, <jeff.mcgee@intel.com> wrote:
> From: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
>
> Some modules, like i915.ko, needs to detect when certain ACPI features are
> active inorder to prevent corruption on contended resources.
> In particular, use of BIOS RapidStart Technology may corrupt the contents of
> the reserved graphics memory, due to unalarmed hibernation. In which case
> i915.ko cannot assume that it (reserved gfx memory) remains unmodified and
> must recreate the contents and importantly not use it to store unrecoverable
> user data.
The above doesn't explain why you need to export acpi_bus_type at all.
I suspect that this is in order to be able to do some hackish stuff on
it, so I'm not going to approve this patch as is.
> Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Cc: linux-acpi@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Jeff McGee <jeff.mcgee@intel.com>
> ---
> drivers/acpi/scan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 4b22ea8..7461bab 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -1269,6 +1269,7 @@ struct bus_type acpi_bus_type = {
> .remove = acpi_device_remove,
> .uevent = acpi_device_uevent,
> };
> +EXPORT_SYMBOL_GPL(acpi_bus_type);
>
> static void acpi_device_del(struct acpi_device *device)
> {
> --
Thanks,
Rafael
next prev parent reply other threads:[~2016-08-30 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160830164910.1248-1-jeff.mcgee@intel.com>
2016-08-30 16:49 ` [PATCH 10/15] acpi: Export acpi_bus_type jeff.mcgee
2016-08-30 22:47 ` Rafael J. Wysocki [this message]
2016-08-30 23:09 ` Jeff McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0h92aJ_tc+-07-kaU-HYO+Q4U28Ly2kXYJi8vr9A-VXOQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=ankitprasad.r.sharma@intel.com \
--cc=isg-gms@eclists.intel.com \
--cc=jeff.mcgee@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).