From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Falla Coulibaly <fallacoulibalyz@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/power: Remove blk_status_to_errno in hib_wait_io
Date: Wed, 15 Sep 2021 14:18:31 +0200 [thread overview]
Message-ID: <CAJZ5v0hBOzx=p+4t0KrnzfhapBaUkRzeuRKkY-oX=U4qwey-9Q@mail.gmail.com> (raw)
In-Reply-To: <20210818214740.3743-1-fallacoulibalyz@gmail.com>
On Wed, Aug 18, 2021 at 11:48 PM Falla Coulibaly
<fallacoulibalyz@gmail.com> wrote:
>
> blk_status_to_errno doesn't appear to perform extra work besides
> converting blk_status_t to integer. This patch removes that unnecessary
> conversion as the return type of the function is blk_status_t.
>
> Signed-off-by: Falla Coulibaly <fallacoulibalyz@gmail.com>
> ---
> kernel/power/swap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 3cb89baebc79..9ec418955556 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -306,7 +306,7 @@ static blk_status_t hib_wait_io(struct hib_bio_batch *hb)
> * a plug will flush the plug list before sleeping.
> */
> wait_event(hb->wait, atomic_read(&hb->count) == 0);
> - return blk_status_to_errno(hb->error);
> + return hb->error;
> }
>
> /*
> --
Applied as 5.16 material, thanks!
prev parent reply other threads:[~2021-09-15 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 21:47 [PATCH] kernel/power: Remove blk_status_to_errno in hib_wait_io Falla Coulibaly
2021-09-15 12:18 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0hBOzx=p+4t0KrnzfhapBaUkRzeuRKkY-oX=U4qwey-9Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=fallacoulibalyz@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).