From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Dietmar Eggemann <Dietmar.Eggemann@arm.com>
Subject: Re: [PATCH] PM / EM: postpone creating the debugfs dir till fs_initcall
Date: Tue, 23 Mar 2021 19:55:12 +0100 [thread overview]
Message-ID: <CAJZ5v0hD1qz1RDQpj47fkK4p_q2xSB84kx6bCenj4P6s-n9HsQ@mail.gmail.com> (raw)
In-Reply-To: <39cee1e7-c085-88d2-9b3b-e4ffbbee04eb@arm.com>
On Tue, Mar 23, 2021 at 4:57 PM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
>
>
> On 3/23/21 3:26 PM, Greg KH wrote:
> > On Tue, Mar 23, 2021 at 02:56:08PM +0000, Lukasz Luba wrote:
> >> The debugfs directory '/sys/kernel/debug/energy_model' is needed before
> >> the Energy Model registration can happen. With the recent change in
> >> debugfs subsystem it's not allowed to create this directory at early stage
> >> (core_initcall). Thus creating this directory would fail.
> >> Postpone the creation of the EM debug dir to later stage: fs_initcall.
> >> It should be safe since all clients: CPUFreq drivers, Devfreq drivers will
> >> be initialized in later stages.
> >> The custom debug log below prints the time of creation the EM debug dir at
> >> fs_initcall and successful registration of EMs at later stages.
> >>
> >> [ 1.505717] energy_model: creating rootdir
> >> [ 3.698307] cpu cpu0: EM: created perf domain
> >> [ 3.709022] cpu cpu1: EM: created perf domain
> >>
> >> fixes: 56348560d495 ("debugfs: do not attempt to create a new file before the filesystem is initalized")
> >> Reported-by: Ionela Voinescu <ionela.voinescu@arm.com>
> >> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> >> ---
> >> Hi Rafael,
> >>
> >> Please take this patch into your PM v5.12 fixes. The change described in
> >> the patch above landed in v5.12-rc1. Some of our EAS/EM tests are failing.
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
>
> Thank you Greg!
Applied as 5.12-rc material, thanks!
next prev parent reply other threads:[~2021-03-23 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 14:56 [PATCH] PM / EM: postpone creating the debugfs dir till fs_initcall Lukasz Luba
2021-03-23 15:26 ` Greg KH
2021-03-23 15:57 ` Lukasz Luba
2021-03-23 18:55 ` Rafael J. Wysocki [this message]
2021-03-24 9:39 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0hD1qz1RDQpj47fkK4p_q2xSB84kx6bCenj4P6s-n9HsQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=Dietmar.Eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).