From: "Rafael J. Wysocki" <rafael@kernel.org>
To: egranata@google.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
gwendal@chromium.org, Dmitry Torokhov <dtor@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Enrico Granata <egranata@chromium.org>
Subject: Re: [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq()
Date: Thu, 7 Feb 2019 19:57:56 +0100 [thread overview]
Message-ID: <CAJZ5v0hJ2-_eiqGGrugk+bvsZ0Hmdybwz=7LQnx1nxO7KdbV8A@mail.gmail.com> (raw)
In-Reply-To: <20190207185043.158981-1-egranata@google.com>
On Thu, Feb 7, 2019 at 7:50 PM <egranata@google.com> wrote:
>
> From: Enrico Granata <egranata@chromium.org>
>
> ACPI 5 added support for GpioInt resources as a way to provide
> information about interrupts mediated via a GPIO controller.
>
> Several device buses (e.g. SPI, I2C) have support for retrieving
> an IRQ specified via this type of resource, and providing it
> directly to the driver as an IRQ number.
> This is not currently done for the platform drivers, as platform_get_irq()
> does not try to parse GpioInt() resources.
>
> This commit adds that functionality.
>
> Signed-off-by: Enrico Granata <egranata@chromium.org>
Please resend this patch with a CC to the linux-acpi@vger.kernel.org
mailing list.
Thanks!
> ---
> drivers/base/platform.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 1c958eb33ef4d..c50c4f9033aef 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -127,7 +127,17 @@ int platform_get_irq(struct platform_device *dev, unsigned int num)
> irqd_set_trigger_type(irqd, r->flags & IORESOURCE_BITS);
> }
>
> - return r ? r->start : -ENXIO;
> + if (r)
> + return r->start;
> +
> + /*
> + * If no IRQ was found, try to parse ACPI GpioInt resources
> + * as a last resort.
> + */
> + if (has_acpi_companion(&dev->dev))
> + return acpi_dev_gpio_irq_get(ACPI_COMPANION(&dev->dev), num);
> +
> + return -ENXIO;
> #endif
> }
> EXPORT_SYMBOL_GPL(platform_get_irq);
> --
> 2.20.1.611.gfbb209baf1-goog
>
next prev parent reply other threads:[~2019-02-07 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:50 [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq() egranata
2019-02-07 18:57 ` Rafael J. Wysocki [this message]
2019-02-07 18:59 egranata
2019-02-07 19:02 ` Rafael J. Wysocki
2019-02-07 19:39 ` Andy Shevchenko
2019-02-07 19:45 ` Andy Shevchenko
2019-02-07 19:55 ` Enrico Granata
[not found] ` <CAPR809vnpuh8nOjU3QMCh6YJUKmtX92+bnHSUKGiAXAp6NwCHQ@mail.gmail.com>
2019-02-07 20:18 ` Andy Shevchenko
2019-02-07 20:29 ` Dmitry Torokhov
2019-02-11 10:30 ` Mika Westerberg
2019-02-11 15:42 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0hJ2-_eiqGGrugk+bvsZ0Hmdybwz=7LQnx1nxO7KdbV8A@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=briannorris@chromium.org \
--cc=dtor@chromium.org \
--cc=egranata@chromium.org \
--cc=egranata@google.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).