From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbcEJShG (ORCPT ); Tue, 10 May 2016 14:37:06 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36472 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbcEJShD (ORCPT ); Tue, 10 May 2016 14:37:03 -0400 MIME-Version: 1.0 In-Reply-To: <1462893601-8937-8-git-send-email-tn@semihalf.com> References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> Date: Tue, 10 May 2016 20:37:00 +0200 X-Google-Sender-Auth: 9exAEQ1hb3TEa_isrP-m0MqB5vA Message-ID: Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. From: "Rafael J. Wysocki" To: Tomasz Nowicki Cc: Bjorn Helgaas , Arnd Bergmann , Will Deacon , Catalin Marinas , "Rafael J. Wysocki" , Hanjun Guo , Lorenzo Pieralisi , Sinan Kaya , jchandra@broadcom.com, robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, David Daney , wangyijing@huawei.com, Suravee Suthikulanit , Mark Salter , Linux PCI , "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" , Jon Masters , andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, liudongdong3@huawei.com, Christopher Covington Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2016 at 5:19 PM, Tomasz Nowicki wrote: > This patch provides a way to set the ACPI companion in PCI code. > We define acpi_pci_set_companion() to set the ACPI companion pointer and > call it from PCI core code. The function is stub for now. > > Signed-off-by: Jayachandran C > Signed-off-by: Tomasz Nowicki > --- > drivers/pci/probe.c | 2 ++ > include/linux/pci-acpi.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8004f67..fb0b752 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2141,6 +2142,7 @@ struct pci_bus *pci_create_root_bus(struct device *parent, int bus, > bridge->dev.parent = parent; > bridge->dev.release = pci_release_host_bridge_dev; > dev_set_name(&bridge->dev, "pci%04x:%02x", pci_domain_nr(b), bus); > + acpi_pci_set_companion(bridge); Yes, we'll probably add something similar here. Do I think now is the right time to do that? No. > error = pcibios_root_bridge_prepare(bridge); > if (error) { > kfree(bridge); > diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h > index 09f9f02..1baa515 100644 > --- a/include/linux/pci-acpi.h > +++ b/include/linux/pci-acpi.h > @@ -111,6 +111,10 @@ static inline void acpi_pci_add_bus(struct pci_bus *bus) { } > static inline void acpi_pci_remove_bus(struct pci_bus *bus) { } > #endif /* CONFIG_ACPI */ > > +static inline void acpi_pci_set_companion(struct pci_host_bridge *bridge) > +{ > +} > + > static inline int acpi_pci_bus_domain_nr(struct pci_bus *bus) > { > return 0; > -- Honestly, to me it looks like this series is trying very hard to avoid doing any PCI host bridge configuration stuff from arch/arm64/ although (a) that might be simpler and (b) it would allow us to identify the code that's common between *all* architectures using ACPI support for host bridge configuration and to move *that* to a common place later. As done here it seems to be following the "ARM64 is generic and the rest of the world is special" line which isn't really helpful.