From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79BAC4363D for ; Fri, 2 Oct 2020 14:11:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71EA8206B6 for ; Fri, 2 Oct 2020 14:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601647905; bh=uq+FfjPcbqe2IPxOCYToz0IyH/g4c6dDKXbECDXSj1c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=LxqpW9pwglBCK5vqfNPw79Xm1VSlXJoqFuwenxfR4Vyq7fdbW9fhAhC5RzkzhC16C oUrkAKomFFABtJdASnmU8E4LV0aoEKktZbxrScg1ufeNnOlWFNb2GL0elVLs0hyEUo gzfQUSpnnPe7APUORI0JLE4qE3zw/x431QI5v0XY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388026AbgJBOLo (ORCPT ); Fri, 2 Oct 2020 10:11:44 -0400 Received: from mail-oo1-f66.google.com ([209.85.161.66]:44754 "EHLO mail-oo1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgJBOLo (ORCPT ); Fri, 2 Oct 2020 10:11:44 -0400 Received: by mail-oo1-f66.google.com with SMTP id 4so360331ooh.11; Fri, 02 Oct 2020 07:11:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gesR1T7BjDx7faU3zrJze9mnQNTvk17XfofPixkh6R8=; b=QW8OOsrdMU3X1mmWnuPD1RPNM1RSkCRFqhJD//qTq0SyAXJ8Hhumtw9ErobE+i4eWC LLflRUs+NkycEgZ/Y3iKa0ck8w4Rb6lJdE02LhBgnsT4QSNvoZKXP/QZ1gcwAsR/TlEG tOxO6YhLUzMfORdHGvhk1wh0E/zvj/7TslSF4XqgArrcH3xA+t4gGPuxUCoH4Wa/bkYL kqMHSCYtmuH9Ez/5S9GwIa9zetXLPUH2HDk01ycfQmP5flKFrAIfvd/Mi416jAvzANFk cdlLSq7v+JDhxEcjyvJbNsz7lcXxUcE4kgKJnAgRHkxhCTmJA6CaNNK2X5+wJU7zwLL/ lQUA== X-Gm-Message-State: AOAM530vxyF1ujhCm9/hqMFKRGSLG1OakTCfiOxPvKJIv5ck1wLU8S5N eMb+5baVWyUhZTLcI2N/vGWd7hZraP4qxSeqtxdD2B2M X-Google-Smtp-Source: ABdhPJyOChhrOxMlaFI5j/v7n2WWIa9JJ6DsWupxqoyuqq9cx0MDNFvfbr/1n5VWiIB1HK6C3AQJgvKcYqwj5k3CjaE= X-Received: by 2002:a4a:e946:: with SMTP id v6mr2068079ood.38.1601647903052; Fri, 02 Oct 2020 07:11:43 -0700 (PDT) MIME-Version: 1.0 References: <20200925161447.1486883-1-hch@lst.de> <20200925161447.1486883-3-hch@lst.de> <20201002065015.GA9691@lst.de> In-Reply-To: <20201002065015.GA9691@lst.de> From: "Rafael J. Wysocki" Date: Fri, 2 Oct 2020 16:11:30 +0200 Message-ID: Subject: Re: [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk in software_resume To: Christoph Hellwig Cc: "Rafael J. Wysocki" , Tejun Heo , Jens Axboe , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Minho Ban , cgroups@vger.kernel.org, linux-block@vger.kernel.org, Linux Kernel Mailing List , Linux PM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 2, 2020 at 8:50 AM Christoph Hellwig wrote: > > On Wed, Sep 30, 2020 at 05:45:27PM +0200, Rafael J. Wysocki wrote: > > On Fri, Sep 25, 2020 at 6:15 PM Christoph Hellwig wrote: > > > > > > get_gendisk grabs a reference on the disk and file operation, so this > > > code will leak both of them while having absolutely no use for the > > > gendisk itself. > > > > > > This effectively reverts commit 2df83fa4bce421f > > > ("PM / Hibernate: Use get_gendisk to verify partition if resume_file is integer format") > > > > > > Signed-off-by: Christoph Hellwig > > > > Acked-by: Rafael J. Wysocki > > Can you pick it up through the PM tree? The big rework in this area > I have planned won't land before 5.11 anyway. Will do, thanks!