From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 850A7C4361B for ; Mon, 7 Dec 2020 13:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4629423339 for ; Mon, 7 Dec 2020 13:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgLGNPJ (ORCPT ); Mon, 7 Dec 2020 08:15:09 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:46694 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbgLGNPJ (ORCPT ); Mon, 7 Dec 2020 08:15:09 -0500 Received: by mail-oi1-f194.google.com with SMTP id k2so15295635oic.13; Mon, 07 Dec 2020 05:14:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s6MWkWXGonlQB+AtEO8xx9v7vK3wSSHws2hVIkSBy6A=; b=NBD9lEMKVr4OE0d9E8crWSebQjFwl662KvmS4RjCWDIK4oOsqXz6eM3PjIH5cBSJOo P2IDm/nQrJVyMiSSQA9fDiQTeoTSdcoueJxxsjihB1/g5RvD438d2eHS3Q+JxA7OW5II r/iya3Mh9UVu3cwz0k2A9GU9k/CHWDLFWHDOy2nlh9wjS1/pbOU7PrylJddeH8M482yw HDBnOobV59N5zkHNxfutDEDh5D4vP/1rdi6pk1VLMImoi5LaNFS7h/IKAGJR+4yZoOg+ x0lAirQ3J3gfLgFKx+PL04Inl2roNA25iSgOddBF9EDeOzcXccGaRgv4QLcuAcb2oN+b 0Ojw== X-Gm-Message-State: AOAM530BBa3TmZk/lpuB5O2EJG6AEhNaochhUNCyq0kSam5NH1A/rvjM 1MNAnPtQq2zRQfczZCPY/mMsg/D+VaFyU4NljoM= X-Google-Smtp-Source: ABdhPJwCP3xS8uVENTrgNk1lY4pwdaX5cMg2CwSMsWVSXZBicYluNvHKxfjaSvTl7rm5CM4aWTDC+wya4mI+cAe1xbg= X-Received: by 2002:aca:5197:: with SMTP id f145mr3709504oib.71.1607346868278; Mon, 07 Dec 2020 05:14:28 -0800 (PST) MIME-Version: 1.0 References: <20201204182545.8322-1-pierre-louis.bossart@linux.intel.com> In-Reply-To: <20201204182545.8322-1-pierre-louis.bossart@linux.intel.com> From: "Rafael J. Wysocki" Date: Mon, 7 Dec 2020 14:14:11 +0100 Message-ID: Subject: Re: [PATCH] ACPI: fan: fix warning with CONFIG_DEBUG_LOCK_ALLOC To: Pierre-Louis Bossart Cc: Linux Kernel Mailing List , Srinivas Pandruvada , "Rafael J . Wysocki" , Zhang Rui , "Rafael J. Wysocki" , Len Brown , "open list:ACPI FAN DRIVER" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2020 at 7:27 PM Pierre-Louis Bossart wrote: > > On a TigerLake device with CONFIG_DEBUG_LOCK_ALLOC the following > warning is thrown: > > [ 13.784413] BUG: key ffff88810ea5a080 has not been registered! > [ 13.784722] DEBUG_LOCKS_WARN_ON(1) > [ 13.784737] WARNING: CPU: 2 PID: 1 at kernel/locking/lockdep.c:4623 > lockdep_init_map_waits+0x25e/0x310 > [ 13.787831] Call Trace: > [ 13.787902] __kernfs_create_file+0xa5/0x180 > [ 13.788016] sysfs_add_file_mode_ns+0x120/0x270 > [ 13.788138] sysfs_create_file_ns+0xcd/0x120 > [ 13.788256] ? sysfs_add_file_mode_ns+0x270/0x270 > [ 13.788381] ? fan_get_max_state+0x70/0x70 > [ 13.788491] ? sort_r+0x1a5/0x200 > [ 13.788579] acpi_fan_probe+0x63b/0x7a0 > > Dynamically-allocated attributes need to be initialized to make > lockdep happy, see include/linux/sysfs.h > > Fixes: d19e470b6605c ('ACPI: fan: Expose fan performance state information') > Cc: Srinivas Pandruvada > Cc: Rafael J. Wysocki > Signed-off-by: Pierre-Louis Bossart > --- > drivers/acpi/fan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c > index 66c3983f0ccc..9cab806298ff 100644 > --- a/drivers/acpi/fan.c > +++ b/drivers/acpi/fan.c > @@ -357,6 +357,7 @@ static int acpi_fan_get_fps(struct acpi_device *device) > fps->dev_attr.store = NULL; > fps->dev_attr.attr.name = fps->name; > fps->dev_attr.attr.mode = 0444; > + sysfs_attr_init(&fps->dev_attr.attr); > status = sysfs_create_file(&device->dev.kobj, &fps->dev_attr.attr); > if (status) { > int j; > -- This has been fixed in the mainline already AFAICS, by commit 7dc7a8b04f3d ("ACPI: fan: Initialize performance state sysfs attribute").