* [PATCH -next] acpi/bus: fix doc warnings in bus.c
@ 2021-06-08 2:37 Baokun Li
2021-06-09 13:09 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Baokun Li @ 2021-06-08 2:37 UTC (permalink / raw)
To: rjw, lenb, linux-acpi, linux-kernel
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1
Fixes the following W=1 kernel build warning(s):
drivers/acpi/bus.c:437: warning: Function parameter or
member 'handle' not described in 'acpi_bus_notify'
drivers/acpi/bus.c:437: warning: Function parameter or
member 'type' not described in 'acpi_bus_notify'
drivers/acpi/bus.c:437: warning: Function parameter or
member 'data' not described in 'acpi_bus_notify'
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
drivers/acpi/bus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index be7da23fad76..021b85ff990a 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -430,6 +430,9 @@ static void acpi_bus_osc_negotiate_usb_control(void)
/**
* acpi_bus_notify
+ * @handle: Handle to acpi device.
+ * @type: ACPI device event type.
+ * @data: ACPI device data.
* ---------------
* Callback for all 'system-level' device notifications (values 0x00-0x7F).
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] acpi/bus: fix doc warnings in bus.c
2021-06-08 2:37 [PATCH -next] acpi/bus: fix doc warnings in bus.c Baokun Li
@ 2021-06-09 13:09 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-06-09 13:09 UTC (permalink / raw)
To: Baokun Li
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List, Wei Yongjun, Yue Haibing, yangjihong1,
yu kuai
On Tue, Jun 8, 2021 at 4:28 AM Baokun Li <libaokun1@huawei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/acpi/bus.c:437: warning: Function parameter or
> member 'handle' not described in 'acpi_bus_notify'
> drivers/acpi/bus.c:437: warning: Function parameter or
> member 'type' not described in 'acpi_bus_notify'
> drivers/acpi/bus.c:437: warning: Function parameter or
> member 'data' not described in 'acpi_bus_notify'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/acpi/bus.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index be7da23fad76..021b85ff990a 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -430,6 +430,9 @@ static void acpi_bus_osc_negotiate_usb_control(void)
>
> /**
> * acpi_bus_notify
> + * @handle: Handle to acpi device.
> + * @type: ACPI device event type.
> + * @data: ACPI device data.
This just addresses specific warnings without really fixing the entire
kerneldoc.
Please either fix it entirely, or don't change it.
> * ---------------
> * Callback for all 'system-level' device notifications (values 0x00-0x7F).
> */
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 13:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 2:37 [PATCH -next] acpi/bus: fix doc warnings in bus.c Baokun Li
2021-06-09 13:09 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).