From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Hector Martin <marcan@marcan.st>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Arnd Bergmann <arnd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Samsung SoC <linux-samsung-soc@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 6/7] tty: serial: samsung_tty: Support runtime PM
Date: Wed, 6 Oct 2021 15:25:23 +0200 [thread overview]
Message-ID: <CAJZ5v0hWC0UxwVrCdJ64rR66UYwdMhCvkYKV00sTeZ2m4-AonQ@mail.gmail.com> (raw)
In-Reply-To: <77ae3bb1-6da5-3ec6-de33-5e5f661b6145@canonical.com>
On Wed, Oct 6, 2021 at 9:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 05/10/2021 17:59, Hector Martin wrote:
> > This allows idle UART devices to be suspended using the standard
> > runtime-PM framework. The logic is modeled after stm32-usart.
> >
> > Signed-off-by: Hector Martin <marcan@marcan.st>
> > ---
> > drivers/tty/serial/samsung_tty.c | 88 ++++++++++++++++++++------------
> > 1 file changed, 54 insertions(+), 34 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> > index e2f49863e9c2..d68e3341adc6 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -40,6 +40,7 @@
> > #include <linux/clk.h>
> > #include <linux/cpufreq.h>
> > #include <linux/of.h>
> > +#include <linux/pm_runtime.h>
> > #include <asm/irq.h>
> >
> > /* UART name and device definitions */
> > @@ -1381,31 +1382,49 @@ static void exynos_usi_init(struct uart_port *port)
> >
> > /* power power management control */
> >
> > -static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
> > - unsigned int old)
> > +static int __maybe_unused s3c24xx_serial_runtime_suspend(struct device *dev)
> > {
> > + struct uart_port *port = dev_get_drvdata(dev);
> > struct s3c24xx_uart_port *ourport = to_ourport(port);
> > int timeout = 10000;
> >
> > - ourport->pm_level = level;
> > + while (--timeout && !s3c24xx_serial_txempty_nofifo(port))
> > + udelay(100);
> >
> > - switch (level) {
> > - case 3:
> > - while (--timeout && !s3c24xx_serial_txempty_nofifo(port))
> > - udelay(100);
> > + if (!IS_ERR(ourport->baudclk))
> > + clk_disable_unprepare(ourport->baudclk);
> >
> > - if (!IS_ERR(ourport->baudclk))
> > - clk_disable_unprepare(ourport->baudclk);
> > + clk_disable_unprepare(ourport->clk);
> > + return 0;
> > +};
> >
> > - clk_disable_unprepare(ourport->clk);
> > - break;
> > +static int __maybe_unused s3c24xx_serial_runtime_resume(struct device *dev)
> > +{
> > + struct uart_port *port = dev_get_drvdata(dev);
> > + struct s3c24xx_uart_port *ourport = to_ourport(port);
> >
> > - case 0:
> > - clk_prepare_enable(ourport->clk);
> > + clk_prepare_enable(ourport->clk);
> >
> > - if (!IS_ERR(ourport->baudclk))
> > - clk_prepare_enable(ourport->baudclk);
> > + if (!IS_ERR(ourport->baudclk))
> > + clk_prepare_enable(ourport->baudclk);
> > + return 0;
> > +};
> > +
> > +static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
> > + unsigned int old)
> > +{
> > + struct s3c24xx_uart_port *ourport = to_ourport(port);
> > +
> > + ourport->pm_level = level;
> >
> > + switch (level) {
> > + case UART_PM_STATE_OFF:
> > + pm_runtime_mark_last_busy(port->dev);
> > + pm_runtime_put_sync(port->dev);
> > + break;
> > +
> > + case UART_PM_STATE_ON:
> > + pm_runtime_get_sync(port->dev);
> > exynos_usi_init(port);
> > break;
> > default:
> > @@ -2282,18 +2301,15 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
> > }
> > }
> >
> > + pm_runtime_get_noresume(&pdev->dev);
> > + pm_runtime_set_active(&pdev->dev);
> > + pm_runtime_enable(&pdev->dev);
> > +
>
> You need to cleanup in error paths (put/disable).
>
> > dev_dbg(&pdev->dev, "%s: adding port\n", __func__);
> > uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> > platform_set_drvdata(pdev, &ourport->port);
> >
> > - /*
> > - * Deactivate the clock enabled in s3c24xx_serial_init_port here,
> > - * so that a potential re-enablement through the pm-callback overlaps
> > - * and keeps the clock enabled in this case.
> > - */
> > - clk_disable_unprepare(ourport->clk);
> > - if (!IS_ERR(ourport->baudclk))
> > - clk_disable_unprepare(ourport->baudclk);
> > + pm_runtime_put_sync(&pdev->dev);
> >
> > ret = s3c24xx_serial_cpufreq_register(ourport);
> > if (ret < 0)
> > @@ -2309,8 +2325,14 @@ static int s3c24xx_serial_remove(struct platform_device *dev)
> > struct uart_port *port = s3c24xx_dev_to_port(&dev->dev);
> >
> > if (port) {
> > + pm_runtime_get_sync(&dev->dev);
>
> 1. You need to check return status.
Why? What can be done differently if the resume fails?
> 2. Why do you need to resume the device here?
This appears to be to prevent the device from suspending after the given point.
> > +
> > s3c24xx_serial_cpufreq_deregister(to_ourport(port));
> > uart_remove_one_port(&s3c24xx_uart_drv, port);
> > +
> > + pm_runtime_disable(&dev->dev);
>
> Why disabling it only if port!=NULL? Can remove() be called if
> platform_set_drvdata() was not?
>
> > + pm_runtime_set_suspended(&dev->dev);
> > + pm_runtime_put_noidle(&dev->dev);
> > }
> >
> > uart_unregister_driver(&s3c24xx_uart_drv);
> > @@ -2319,8 +2341,8 @@ static int s3c24xx_serial_remove(struct platform_device *dev)
> > }
> >
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2021-10-06 13:25 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 15:59 [PATCH 0/7] Apple SoC PMGR device power states driver Hector Martin
2021-10-05 15:59 ` [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding Hector Martin
2021-10-05 20:09 ` Mark Kettenis
2021-10-05 22:45 ` Rob Herring
2021-10-06 15:17 ` Hector Martin
2021-10-06 6:56 ` Krzysztof Kozlowski
2021-10-06 7:30 ` Krzysztof Kozlowski
2021-10-06 15:21 ` Hector Martin
2021-10-06 15:26 ` Hector Martin
2021-10-07 13:10 ` Krzysztof Kozlowski
2021-10-05 15:59 ` [PATCH 2/7] dt-bindings: power: Add apple,pmgr-pwrstate binding Hector Martin
2021-10-05 20:16 ` Mark Kettenis
2021-10-06 15:27 ` Hector Martin
2021-10-06 0:58 ` Rob Herring
2021-10-06 15:52 ` Hector Martin
2021-10-06 15:55 ` Hector Martin
2021-10-08 7:50 ` Krzysztof Kozlowski
2021-10-11 5:17 ` Hector Martin
2021-10-06 7:05 ` Krzysztof Kozlowski
2021-10-06 15:59 ` Hector Martin
2021-10-07 13:12 ` Krzysztof Kozlowski
2021-10-11 4:42 ` Hector Martin
2021-10-05 15:59 ` [PATCH 3/7] soc: apple: Add driver for Apple PMGR power state controls Hector Martin
2021-10-05 16:08 ` Linus Walleij
2021-10-05 16:15 ` Hector Martin
2021-10-05 19:49 ` Linus Walleij
2021-10-05 20:21 ` Mark Kettenis
2021-10-06 16:00 ` Hector Martin
2021-10-06 7:28 ` Krzysztof Kozlowski
2021-10-06 16:08 ` Hector Martin
2021-10-06 9:24 ` Philipp Zabel
2021-10-06 16:11 ` Hector Martin
2021-10-05 15:59 ` [PATCH 4/7] arm64: dts: apple: t8103: Rename clk24 to clkref Hector Martin
2021-10-05 20:22 ` Mark Kettenis
2021-10-05 15:59 ` [PATCH 5/7] arm64: dts: apple: t8103: Add the UART PMGR tree Hector Martin
2021-10-05 20:25 ` Mark Kettenis
2021-10-05 15:59 ` [PATCH 6/7] tty: serial: samsung_tty: Support runtime PM Hector Martin
2021-10-06 7:43 ` Krzysztof Kozlowski
2021-10-06 13:25 ` Rafael J. Wysocki [this message]
2021-10-06 13:29 ` Krzysztof Kozlowski
2021-10-11 5:32 ` Hector Martin
2021-10-11 6:48 ` Krzysztof Kozlowski
2021-10-11 8:27 ` Johan Hovold
2021-10-05 15:59 ` [PATCH 7/7] arm64: dts: apple: t8103: Add UART2 Hector Martin
2021-10-05 20:26 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0hWC0UxwVrCdJ64rR66UYwdMhCvkYKV00sTeZ2m4-AonQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=arnd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).