* [PATCH] device property: Fix documentation for fwnode_get_next_parent()
@ 2022-12-07 11:22 Miaoqian Lin
2022-12-07 11:32 ` Andy Shevchenko
2022-12-07 12:21 ` Sakari Ailus
0 siblings, 2 replies; 6+ messages in thread
From: Miaoqian Lin @ 2022-12-07 11:22 UTC (permalink / raw)
To: Andy Shevchenko, Daniel Scally, Heikki Krogerus, Sakari Ailus,
Greg Kroah-Hartman, Rafael J. Wysocki, Mika Westerberg,
linux-acpi, linux-kernel
Cc: linmq006
Use fwnode_handle_put() on the node pointer to release the refcount.
Change fwnode_handle_node() to fwnode_handle_put().
Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/base/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/property.c b/drivers/base/property.c
index 2a5a37fcd998..daa1e379762b 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
* node's parents.
*
* Returns a node pointer with refcount incremented, use
- * fwnode_handle_node() on it when done.
+ * fwnode_handle_put() on it when done.
*/
struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()
2022-12-07 11:22 [PATCH] device property: Fix documentation for fwnode_get_next_parent() Miaoqian Lin
@ 2022-12-07 11:32 ` Andy Shevchenko
2022-12-07 11:37 ` Daniel Scally
2022-12-07 12:21 ` Sakari Ailus
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2022-12-07 11:32 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Daniel Scally, Heikki Krogerus, Sakari Ailus, Greg Kroah-Hartman,
Rafael J. Wysocki, Mika Westerberg, linux-acpi, linux-kernel
On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> Use fwnode_handle_put() on the node pointer to release the refcount.
> Change fwnode_handle_node() to fwnode_handle_put().
Looks correct to me, thanks!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/base/property.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 2a5a37fcd998..daa1e379762b 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
> * node's parents.
> *
> * Returns a node pointer with refcount incremented, use
> - * fwnode_handle_node() on it when done.
> + * fwnode_handle_put() on it when done.
> */
> struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> {
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()
2022-12-07 11:32 ` Andy Shevchenko
@ 2022-12-07 11:37 ` Daniel Scally
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Scally @ 2022-12-07 11:37 UTC (permalink / raw)
To: Andy Shevchenko, Miaoqian Lin
Cc: Heikki Krogerus, Sakari Ailus, Greg Kroah-Hartman,
Rafael J. Wysocki, Mika Westerberg, linux-acpi, linux-kernel
On 07/12/2022 11:32, Andy Shevchenko wrote:
> On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
>> Use fwnode_handle_put() on the node pointer to release the refcount.
>> Change fwnode_handle_node() to fwnode_handle_put().
> Looks correct to me, thanks!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
And to me too:
Reviewed-by: Daniel Scally <djrscally@gmail.com>
>
>> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
>> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>> ---
>> drivers/base/property.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>> index 2a5a37fcd998..daa1e379762b 100644
>> --- a/drivers/base/property.c
>> +++ b/drivers/base/property.c
>> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
>> * node's parents.
>> *
>> * Returns a node pointer with refcount incremented, use
>> - * fwnode_handle_node() on it when done.
>> + * fwnode_handle_put() on it when done.
>> */
>> struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
>> {
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()
2022-12-07 11:22 [PATCH] device property: Fix documentation for fwnode_get_next_parent() Miaoqian Lin
2022-12-07 11:32 ` Andy Shevchenko
@ 2022-12-07 12:21 ` Sakari Ailus
2022-12-07 14:30 ` Rafael J. Wysocki
1 sibling, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2022-12-07 12:21 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Andy Shevchenko, Daniel Scally, Heikki Krogerus,
Greg Kroah-Hartman, Rafael J. Wysocki, Mika Westerberg,
linux-acpi, linux-kernel
On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> Use fwnode_handle_put() on the node pointer to release the refcount.
> Change fwnode_handle_node() to fwnode_handle_put().
>
> Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Thanks!
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/base/property.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 2a5a37fcd998..daa1e379762b 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
> * node's parents.
> *
> * Returns a node pointer with refcount incremented, use
> - * fwnode_handle_node() on it when done.
> + * fwnode_handle_put() on it when done.
> */
> struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> {
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()
2022-12-07 12:21 ` Sakari Ailus
@ 2022-12-07 14:30 ` Rafael J. Wysocki
2022-12-07 16:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2022-12-07 14:30 UTC (permalink / raw)
To: Sakari Ailus
Cc: Miaoqian Lin, Andy Shevchenko, Daniel Scally, Heikki Krogerus,
Greg Kroah-Hartman, Rafael J. Wysocki, Mika Westerberg,
linux-acpi, linux-kernel
On Wed, Dec 7, 2022 at 1:21 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> > Use fwnode_handle_put() on the node pointer to release the refcount.
> > Change fwnode_handle_node() to fwnode_handle_put().
> >
> > Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> Thanks!
>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
So I'm assuming that Greg will pick up this one or please let me know otherwise.
> > ---
> > drivers/base/property.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index 2a5a37fcd998..daa1e379762b 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -601,7 +601,7 @@ EXPORT_SYMBOL_GPL(fwnode_get_parent);
> > * node's parents.
> > *
> > * Returns a node pointer with refcount incremented, use
> > - * fwnode_handle_node() on it when done.
> > + * fwnode_handle_put() on it when done.
> > */
> > struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> > {
>
> --
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] device property: Fix documentation for fwnode_get_next_parent()
2022-12-07 14:30 ` Rafael J. Wysocki
@ 2022-12-07 16:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-12-07 16:21 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Sakari Ailus, Miaoqian Lin, Andy Shevchenko, Daniel Scally,
Heikki Krogerus, Mika Westerberg, linux-acpi, linux-kernel
On Wed, Dec 07, 2022 at 03:30:43PM +0100, Rafael J. Wysocki wrote:
> On Wed, Dec 7, 2022 at 1:21 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > On Wed, Dec 07, 2022 at 03:22:18PM +0400, Miaoqian Lin wrote:
> > > Use fwnode_handle_put() on the node pointer to release the refcount.
> > > Change fwnode_handle_node() to fwnode_handle_put().
> > >
> > > Fixes: 233872585de1 ("device property: Add fwnode_get_next_parent()")
> > > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> >
> > Thanks!
> >
> > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> So I'm assuming that Greg will pick up this one or please let me know otherwise.
I'll grab it now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-07 16:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 11:22 [PATCH] device property: Fix documentation for fwnode_get_next_parent() Miaoqian Lin
2022-12-07 11:32 ` Andy Shevchenko
2022-12-07 11:37 ` Daniel Scally
2022-12-07 12:21 ` Sakari Ailus
2022-12-07 14:30 ` Rafael J. Wysocki
2022-12-07 16:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).