From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kernel test robot" <rong.a.chen@intel.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Richard Weinberger" <richard@nod.at>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Alban Bedel" <albeu@free.fr>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Boris Brezillon" <boris.brezillon@bootlin.com>,
LKML <linux-kernel@vger.kernel.org>, LKP <lkp@01.org>
Subject: Re: [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c
Date: Wed, 2 Jan 2019 22:44:50 +0100 [thread overview]
Message-ID: <CAJZ5v0hXEqtaiV56sGCOd1VzsRETkS39YiLV-OfnFWiZH4tcAQ@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wh2sparb1qw4h5QTCR+YF7xsssLgZtNtthRA6QiJjKfbA@mail.gmail.com>
On Wed, Jan 2, 2019 at 8:53 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
[cut]
> Greg, Rafael: it does strike me that the "BUG_ON()" in
> sysfs_create_file_ns() could easily have been a
>
> if (WARN_ON(..))
> return -EINVAL;
>
> which would have made the machine boot and probably make things easier
> for normal users to report. The kernel test robot doesn't care, but
> non-booting kernels are usually not nice to debug or report for normal
> human beings..
I agree.
This isn't a good enough reason to crash the kernel IMO.
Cheers,
Rafael
next prev parent reply other threads:[~2019-01-02 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190102005704.GC17624@shao2-debian>
2019-01-02 19:53 ` [LKP] [mtd] c4dfa25ab3: kernel_BUG_at_fs/sysfs/file.c Linus Torvalds
2019-01-02 21:44 ` Rafael J. Wysocki [this message]
2019-01-03 9:26 ` Greg Kroah-Hartman
2019-01-03 9:29 ` Rafael J. Wysocki
2019-01-07 10:25 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0hXEqtaiV56sGCOd1VzsRETkS39YiLV-OfnFWiZH4tcAQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=albeu@free.fr \
--cc=bgolaszewski@baylibre.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=rong.a.chen@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).