From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE100C55178 for ; Tue, 27 Oct 2020 18:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F0E6206C1 for ; Tue, 27 Oct 2020 18:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603823506; bh=GdTGxNnORlq6nt/FpJJ8aXsuRxm7u3VMoRRFmljSaXY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=yFxn9CbkJFs4HaBWrd266cyMmJIcDJyoaA1MuZ6TKqna2kPrC/WOP7XX+ZvjXHF3z IfN4S3sNqJCAxL+Z5VsOoRD8AcJgnrDq8geVAMe+j33uhx3Gf8mlMT5orM7KshABg/ NgHTAso/YBj+NEOKPbyiKgE8STvQ5cyFp/ME8//A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1828391AbgJ0Sbp (ORCPT ); Tue, 27 Oct 2020 14:31:45 -0400 Received: from mail-oo1-f67.google.com ([209.85.161.67]:38937 "EHLO mail-oo1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1828382AbgJ0Sbo (ORCPT ); Tue, 27 Oct 2020 14:31:44 -0400 Received: by mail-oo1-f67.google.com with SMTP id c10so572184oon.6; Tue, 27 Oct 2020 11:31:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cgfDxBRqZFn1I8+lrk1v2IOdukgMx9CwviEf/qzFVes=; b=HixRlBPYT6Yur4+e1IC1zJojA0mc+iq5kufayHW9il9vtqAY/tgd0sO1LCOAbJJFyI 5YvxRuOA1dmOIUHc4WR78ofkJeqZQnIVnwuGPeNdczDgAa3fNwCtDYhYLsoYJAGv8dWd DrAM+Kpxw2wXslcH/JslbgSuZZ4RomGhWuoGa8SWp3KvqmeJar+ezsO6uxaOgRc5R4O5 xXehRB0IvyRjH3otB7EFSBXT9vWF+bVmDLygds5aZOfnDRP/Q+4c6chUxa/hqjy0pEMW ZqYrc383AWoq9neHhWcDcxjlSFEGZlMsVLuVQvVRSn+WOgyoghLpxTFhRfdfOf+MVpyK JJtQ== X-Gm-Message-State: AOAM5320VIareMwk+xMjrqi5IIJCb0VI3euxgNxJ2gAr7jR1LFcaYIDQ r29Yct6oSADJ/8XwCd/TgTI+RSZbnYiJhSSbatxfqZ7q X-Google-Smtp-Source: ABdhPJyCa2qbxR/oafdrncJLycfUCK4Q7+vHYbFgYsqizy2HNjDYmUdGrVixy4cGNeMUEMmr+6A2VSP4c6r4U/QkJBQ= X-Received: by 2002:a4a:dc0d:: with SMTP id p13mr2770015oov.2.1603823503770; Tue, 27 Oct 2020 11:31:43 -0700 (PDT) MIME-Version: 1.0 References: <20201026214838.3892471-1-arnd@kernel.org> In-Reply-To: <20201026214838.3892471-1-arnd@kernel.org> From: "Rafael J. Wysocki" Date: Tue, 27 Oct 2020 19:31:32 +0100 Message-ID: Subject: Re: [PATCH] ACPI: dock: fix enum-conversion warning To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Len Brown , Yinghai Lu , Arnd Bergmann , "Gustavo A. R. Silva" , Hanjun Guo , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2020 at 10:48 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc points out a type mismatch: > > drivers/acpi/dock.c: In function 'hot_remove_dock_devices': > drivers/acpi/dock.c:234:53: warning: implicit conversion from 'enum ' to 'enum dock_callback_type' [-Wenum-conversion] > 234 | dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, false); > > This is harmless because 'false' still has the correct numeric value, > but passing DOCK_CALL_HANDLER documents better what is going on > and avoids the warning. > > Fixes: 37f908778f20 ("ACPI / dock: Walk list in reverse order during removal of devices") > Fixes: f09ce741a03a ("ACPI / dock / PCI: Drop ACPI dock notifier chain") > Signed-off-by: Arnd Bergmann > --- > drivers/acpi/dock.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c > index 45d4b7b69de8..24e076f44d23 100644 > --- a/drivers/acpi/dock.c > +++ b/drivers/acpi/dock.c > @@ -231,7 +231,8 @@ static void hot_remove_dock_devices(struct dock_station *ds) > * between them). > */ > list_for_each_entry_reverse(dd, &ds->dependent_devices, list) > - dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, false); > + dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, > + DOCK_CALL_HANDLER); > > list_for_each_entry_reverse(dd, &ds->dependent_devices, list) > acpi_bus_trim(dd->adev); > -- Applied as 5.10-rc material, thanks!