From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbcFIMuc (ORCPT ); Thu, 9 Jun 2016 08:50:32 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33086 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbcFIMu3 (ORCPT ); Thu, 9 Jun 2016 08:50:29 -0400 MIME-Version: 1.0 In-Reply-To: <20160609102925.GS7510@sirena.org.uk> References: <1465465471-28740-1-git-send-email-k.kozlowski@samsung.com> <1465465471-28740-2-git-send-email-k.kozlowski@samsung.com> <20160609102925.GS7510@sirena.org.uk> From: "Rafael J. Wysocki" Date: Thu, 9 Jun 2016 14:50:26 +0200 X-Google-Sender-Auth: kAG8nsg6j5TUaboPzpZxSs8XzZI Message-ID: Subject: Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies To: Mark Brown Cc: Krzysztof Kozlowski , Ulf Hansson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Liam Girdwood , Greg Kroah-Hartman , Hans de Goede , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Heiko Stuebner , linux-mmc@vger.kernel.org, "devicetree@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, "linux-pm@vger.kernel.org" , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" , "open list:FRAMEBUFFER LAYER" , Peter Chen , Bartlomiej Zolnierkiewicz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 9, 2016 at 12:29 PM, Mark Brown wrote: > On Thu, Jun 09, 2016 at 11:44:18AM +0200, Krzysztof Kozlowski wrote: >> Few drivers have a need of getting regulator supplies without knowing >> their names: >> 1. The Simple Framebuffer driver works on setup provided by bootloader >> (outside of scope of kernel); >> 2. Generic power sequence driver may be attached to any device node. >> >> Add a Device Tree helper for parsing "-supply" properties and returning >> allocated bulk regulator consumers. > > I'm still very concerned that this is just an invitation to people to > write half baked regulator consumers and half baked DTs to go along with > it, making it a standard API that doesn't have big red flags on it that > will flag up when "normal" drivers use it is not good. Right now this > just looks like a standard API and people are going to just start using > it. If we are going to do this perhaps we need a separate header or > something to help flag this up. > > In the case of power sequences I'd expect the sequences to perform > operations on named supplies - the core shouldn't know what the supplies > are but the thing specifying the sequence should. > >> drivers/regulator/of_regulator.c | 86 ++++++++++++++++++++++++++++++++++ >> include/linux/regulator/of_regulator.h | 13 +++++ >> 2 files changed, 99 insertions(+) > > The external interface shouldn't be DT specific, the Intel people are > busy importing all of DT into ACPI Well, not really. If you are referring to the pinctrl proposal discussed recently, that was a proposal from one group at Intel and AFAICS it has been abandoned. > so they'll doubtless want an ACPI version. That is possible, though, so I agree that the external interface should not be DT-specific.