From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DCB8C433F5 for ; Wed, 11 May 2022 17:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345582AbiEKRaW (ORCPT ); Wed, 11 May 2022 13:30:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239654AbiEKRaU (ORCPT ); Wed, 11 May 2022 13:30:20 -0400 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD242317E0; Wed, 11 May 2022 10:30:18 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id r11so5333662ybg.6; Wed, 11 May 2022 10:30:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kA5LUrg9FEK6lcfS6hSBAItDCTrYCnHyDwxKH4zNPeE=; b=km5I3gSzIbTEWdHVVIN/zKLWy7PIJJa/NA7/y5zfX2YPaCmEgmyO5F9Hwrw5ybagmO PhBW/ZhVHk7m0xNMPd9FSDZqRMoa49N8oqiLdq6eYVx2Zj99qhUqPhzyqza+ujOPWIXH VBF8DxZAOrLfWUYfVeEqwIY2tOhS68mUiTmJ4cpWVjCqlupo+xaOwQGhIFYVEDTYWH1d G6uMiVZymvDlMoeURi2KHrBUaQJgC4kEAq/5LbaepN6NM2b6hJhmVQKx7TSgm3rO4LRV 7Fi+FWm4gG8j3x3zycrjPJ+DSu24DcPNJrEsyRrgPo7PiymLLJfrBZ7apTsT/E8SPrJb 2qjQ== X-Gm-Message-State: AOAM531zzEIWUC23Cm4UovjyBr56UnnWJNiA3vUSJfOC+yh2Xwd1ylwD u/BQTPcQ4pmn6EAlWfadInp4oHoXLscWHsuZ7TQ= X-Google-Smtp-Source: ABdhPJzx10oGXmjUdrgRFpSf2JnlUCQLWprnfw47qR/sZ08uGzJzbPZal4vP3IN9LVYQ/6ChRXKsf3TVio6AaBZyTuw= X-Received: by 2002:a25:e792:0:b0:645:7ddb:b5eb with SMTP id e140-20020a25e792000000b006457ddbb5ebmr24694201ybh.482.1652290218179; Wed, 11 May 2022 10:30:18 -0700 (PDT) MIME-Version: 1.0 References: <20220511051605.103574-1-kunyu@nfschina.com> In-Reply-To: <20220511051605.103574-1-kunyu@nfschina.com> From: "Rafael J. Wysocki" Date: Wed, 11 May 2022 19:30:07 +0200 Message-ID: Subject: Re: [PATCH] x86: The return type of the function could be void To: Li kunyu Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 7:16 AM Li kunyu wrote: > > perhaps the return value of the function is not used. > it may be possible to optimize the execution instructions. > > Signed-off-by: Li kunyu > --- > arch/x86/kernel/acpi/boot.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c > index 0d01e7f5078c..7e32e33d52fa 100644 > --- a/arch/x86/kernel/acpi/boot.c > +++ b/arch/x86/kernel/acpi/boot.c > @@ -375,7 +375,7 @@ static void __init mp_override_legacy_irq(u8 bus_irq, u8 polarity, u8 trigger, > isa_irq_to_gsi[bus_irq] = gsi; > } > > -static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger, > +static void mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger, > int polarity) > { > #ifdef CONFIG_X86_MPPARSE > @@ -387,9 +387,9 @@ static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger, > u8 pin; > > if (!acpi_ioapic) > - return 0; > + return; > if (!dev || !dev_is_pci(dev)) > - return 0; > + return; > > pdev = to_pci_dev(dev); > number = pdev->bus->number; > @@ -408,7 +408,6 @@ static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger, > > mp_save_irq(&mp_irq); > #endif > - return 0; > } > > static int __init mp_register_ioapic_irq(u8 bus_irq, u8 polarity, > -- Applied as 5.19 material with rewritten subject and changelog, thanks!