linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Len Brown <len.brown@intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] Documentation: admin-guide: PM: Add cpuidle document
Date: Wed, 28 Nov 2018 10:11:16 +0100	[thread overview]
Message-ID: <CAJZ5v0hnX512AheTwhpj09+eyiyv6txsgGQcT2afWiB2JjjCzw@mail.gmail.com> (raw)
In-Reply-To: <20181128054835.gnhistcfxy25rmwf@vireshk-i7>

On Wed, Nov 28, 2018 at 6:48 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 26-11-18, 14:11, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Important information is missing from user/admin cpuidle documentation
> > available today, so add a new user/admin document for cpuidle containing
> > current and comprehensive information to admin-guide and drop the old
> > .txt documents it is replacing.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> >  Documentation/admin-guide/pm/cpuidle.rst       |  603 +++++++++++++++++++++++++
> >  Documentation/admin-guide/pm/working-state.rst |    1
> >  Documentation/cpuidle/core.txt                 |   23
> >  Documentation/cpuidle/sysfs.txt                |   98 ----
> >  4 files changed, 604 insertions(+), 121 deletions(-)
>
> Nice work Rafael. Minor nits below..

Thanks for the typo fixes.  The spellchecker I have here evidently doesn't work.

[cut]

> Maybe I missed, but I couldn't find any text that says what state 0, 1, ... N
> mean.

There is a paragraph on that above.

> Like which is the deepest idle state and which one is the shallowest.

But this part is missing, good catch!

Thanks,
Rafael

  reply	other threads:[~2018-11-28  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 13:11 [PATCH] Documentation: admin-guide: PM: Add cpuidle document Rafael J. Wysocki
2018-11-28  5:48 ` Viresh Kumar
2018-11-28  9:11   ` Rafael J. Wysocki [this message]
2018-11-28  9:31     ` Viresh Kumar
2018-11-28 10:01       ` Rafael J. Wysocki
2018-11-28 10:07         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0hnX512AheTwhpj09+eyiyv6txsgGQcT2afWiB2JjjCzw@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=ggherdovich@suse.cz \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).