From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC80C433FF for ; Wed, 7 Aug 2019 10:54:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58C4721E6A for ; Wed, 7 Aug 2019 10:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565175262; bh=xxw3EVVU0xzOlP4s3CysSd2AtPlOWNcCQsYcbdOHfjQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=i7cTfe/qu2FqJwBXyloa6sZowthDqmh0+VUC4ZWpm5H9jT2rt3m4wDepBB5HRUXDn reGaJSEBOKH1efiWDhz/RrTP9DgQ8Si5DzbJs24WBLmINw4bSlMNq1GWYVHzvm+PJt 90GYt9J2BYkxnVSfk/V3WyQ+ui23NJbTV11pyLtY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729179AbfHGKyV (ORCPT ); Wed, 7 Aug 2019 06:54:21 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:35229 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbfHGKyU (ORCPT ); Wed, 7 Aug 2019 06:54:20 -0400 Received: by mail-ot1-f68.google.com with SMTP id j19so25805474otq.2; Wed, 07 Aug 2019 03:54:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xxw3EVVU0xzOlP4s3CysSd2AtPlOWNcCQsYcbdOHfjQ=; b=ONPWXEs6oWT+qMb/aZz3x0zLLalgu+Dj43A4gSwBLKuKKAmmKrjzuUzhiDC84HxTUj frmYLhr1se+sQjwzaMyJSGpZmITST+xTd5QvfexUa+PNwuUAti+ZJygNL4VZXUUqJ1JB uYd+RYcv0OWsfGIuTcVeWP3Sm1aLUya8noPQ1H4vAETowzi7hfIaCY7Z012eYRw7wqZy CHOYT6e7Fv4MXd5wHoyvE5+TuiGfjcF6xF18dAGnwIgwy3XXk+FiXJ3teI3OAnE3LZ8h DeHs+NNtDZhVrfgW5ctf4gLOoi9nRQycQs/wrqQmXFM/ZFKn+G3NNd4EhqayVVOJxuJ0 C/Rg== X-Gm-Message-State: APjAAAVhsOOxFtnzEiWhzjSPdEuwfzqNdCcB0fd0DwqvqFtaZ9gmqqXP ecafg9qTGo6zIkbmrEejXzVjQzAXHAZ+ulV7uPM= X-Google-Smtp-Source: APXvYqxDuPzwIiSna5umdxZjXPi87WcSCTODOBv6ItZIqSnL3x2U+otA38McqxhlujmUrNjhLhaVyLy2i5tERoxxacU= X-Received: by 2002:a05:6830:1516:: with SMTP id k22mr6970595otp.189.1565175259873; Wed, 07 Aug 2019 03:54:19 -0700 (PDT) MIME-Version: 1.0 References: <4323ed84dd07474eab65699b4d007aaf@AUSX13MPC105.AMER.DELL.COM> <20190731221956.GB15795@localhost.localdomain> <2763495.NmdaWeg79L@kreacher> <20190807104500.GB11356@lst.de> In-Reply-To: <20190807104500.GB11356@lst.de> From: "Rafael J. Wysocki" Date: Wed, 7 Aug 2019 12:54:08 +0200 Message-ID: Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems To: Christoph Hellwig Cc: "Rafael J. Wysocki" , Keith Busch , "Rafael J. Wysocki" , Mario Limonciello , Kai-Heng Feng , Keith Busch , Sagi Grimberg , linux-nvme , Linux PM , Linux Kernel Mailing List , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 7, 2019 at 12:45 PM Christoph Hellwig wrote: > > On Wed, Aug 07, 2019 at 11:48:33AM +0200, Rafael J. Wysocki wrote: > > So I think I know what the problem is here. > > > > If ASPM is disabled for the NVMe device (which is the case on my machine by default), > > skipping the bus-level PM in nvme_suspend() causes the PCIe link of it to stay up and > > that prevents the SoC from getting into deeper package C-states. > > > > If I change the ASPM policy to "powersave" (through the module parameter in there), > > ASPM gets enabled for the NVMe drive and I can get into PC10 via S2Idle with plain 5.3-rc3. > > > > However, that's a bit less than straightforward, so I'm going to post a patch to make > > nvme_suspend() fall back to the "old ways" if ASPM is not enabled for the target device. > > Sounds sensibel. > > FYI your mail is not properly formatted and has way too long lines. Sorry about that.