From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Borislav Petkov <bp@alien8.de>,
Yangtao Li <tiny.windzz@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] acpi: no need to check return value of debugfs_create functions
Date: Tue, 22 Jan 2019 16:52:56 +0100 [thread overview]
Message-ID: <CAJZ5v0htb3Uv28rqwop_8eQPa6pE_1oOPbszL6B522UGfMGiDQ@mail.gmail.com> (raw)
In-Reply-To: <20190122154010.GA19652@kroah.com>
On Tue, Jan 22, 2019 at 4:40 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jan 22, 2019 at 04:28:42PM +0100, Rafael J. Wysocki wrote:
> > On Tue, Jan 22, 2019 at 4:27 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > When calling debugfs functions, there is no need to ever check the
> > > return value. The function can work or not, but the code logic should
> > > never do something different based on this.
> > >
> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > > Cc: Len Brown <lenb@kernel.org>
> > > Cc: Tony Luck <tony.luck@intel.com>
> > > Cc: Borislav Petkov <bp@alien8.de>
> > > Cc: Yangtao Li <tiny.windzz@gmail.com>
> > > Cc: linux-acpi@vger.kernel.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Or do you want me to take this?
>
> It's up to you, I can take it, or you can, either is fine with me :)
OK, I'll take it in case there is a clash with a different patch or similar.
prev parent reply other threads:[~2019-01-22 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:21 [PATCH] acpi: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 15:28 ` Rafael J. Wysocki
2019-01-22 15:40 ` Greg Kroah-Hartman
2019-01-22 15:52 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0htb3Uv28rqwop_8eQPa6pE_1oOPbszL6B522UGfMGiDQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiny.windzz@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).