From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v1 1/1] cpufreq: ACPI: Use str_enabled_disabled() helper
Date: Thu, 3 Nov 2022 19:12:08 +0100 [thread overview]
Message-ID: <CAJZ5v0hzZYdO+U0yrgazZGv243soFv2StB88NZQLr-evs5KreA@mail.gmail.com> (raw)
In-Reply-To: <20221008195244.53813-1-andriy.shevchenko@linux.intel.com>
On Sat, Oct 8, 2022 at 9:52 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Use str_enabled_disabled() helper instead of open coding the same.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/cpufreq/acpi-cpufreq.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 1bb2b90ebb21..8597ab0a84b5 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -19,6 +19,7 @@
> #include <linux/compiler.h>
> #include <linux/dmi.h>
> #include <linux/slab.h>
> +#include <linux/string_helpers.h>
>
> #include <linux/acpi.h>
> #include <linux/io.h>
> @@ -135,8 +136,8 @@ static int set_boost(struct cpufreq_policy *policy, int val)
> {
> on_each_cpu_mask(policy->cpus, boost_set_msr_each,
> (void *)(long)val, 1);
> - pr_debug("CPU %*pbl: Core Boosting %sabled.\n",
> - cpumask_pr_args(policy->cpus), val ? "en" : "dis");
> + pr_debug("CPU %*pbl: Core Boosting %s.\n",
> + cpumask_pr_args(policy->cpus), str_enabled_disabled(val));
>
> return 0;
> }
> --
Applied as 6.2 material, thanks!
prev parent reply other threads:[~2022-11-03 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 19:52 [PATCH v1 1/1] cpufreq: ACPI: Use str_enabled_disabled() helper Andy Shevchenko
2022-11-03 18:12 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0hzZYdO+U0yrgazZGv243soFv2StB88NZQLr-evs5KreA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).