From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC94C3F68F for ; Thu, 12 Dec 2019 16:41:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4B9F2173E for ; Thu, 12 Dec 2019 16:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576168896; bh=kAhkMJgoZo1BWz+qs5Xno3OsSKZ86r1MkClH94NFChM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=jybLoJrmARTGRCFbNCgxDpc1zAuP4tQ7qGyRhSPwIRTjc9dFgoLTGhUEl9NfrMgei VV54d8JUI68mTmhn2D/jWh0VIia9bEDHEPZOzJ17985KSedof1mlr62UHsJYGRRto0 Uo2p5zOndLjaqHzQ8zwjlfZXMgvM3QFc9bH/ueC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729930AbfLLQlg (ORCPT ); Thu, 12 Dec 2019 11:41:36 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:36300 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729852AbfLLQlf (ORCPT ); Thu, 12 Dec 2019 11:41:35 -0500 Received: by mail-oi1-f196.google.com with SMTP id c16so911263oic.3; Thu, 12 Dec 2019 08:41:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kAhkMJgoZo1BWz+qs5Xno3OsSKZ86r1MkClH94NFChM=; b=ZGBqSKgXkEU8zPLpGwOZI18a87nXD3r2fvq+D0pW0f6ala7KTcbSKdwgARMwzpLDo4 /sq6isXWuLTvxs9DS/Od/BRQV71ITatVSEE8jrjkTiQI/F+F6bAy/8MAtD/lKC7CTOvu 8yt+sbayYou0QAebyUFWnsK3+qC4E6/QN1h0DJLlpfocwiR+l7Vnz51BvA4nMGtaADPP dJGrGuvRiL2ONf0lcuvqYuw2Zwj9camNbSiRGy8mXJKS4lj2SLgJPOOYxROStCWYZzq5 1zhmyYzlD73Fz09SK7yo71qm4vVCFOCALtGbpUxvPPlVEAbVv0fDDm0sLv5YVamB1UD2 44zg== X-Gm-Message-State: APjAAAXV64tNbqEUDxHk2raeRvNW+E07L16mGZy1zciz+572uUlwJFdh JLHMnQaOXQdnvrepsOLi/1WCPIFCn9o+xe1++jk= X-Google-Smtp-Source: APXvYqz/HR4b555gMUmBfIr+En2JhqxAwZmSDSEDPYWP867i+78mHmWSktUG5yszyRCA4BCxfwarPEWTLzzeFMNk+PY= X-Received: by 2002:a05:6808:b38:: with SMTP id t24mr5694666oij.110.1576168894436; Thu, 12 Dec 2019 08:41:34 -0800 (PST) MIME-Version: 1.0 References: <20191108042225.45391-1-dmitry.torokhov@gmail.com> <20191108042225.45391-2-dmitry.torokhov@gmail.com> <20191212112825.GK32742@smile.fi.intel.com> In-Reply-To: <20191212112825.GK32742@smile.fi.intel.com> From: "Rafael J. Wysocki" Date: Thu, 12 Dec 2019 17:41:21 +0100 Message-ID: Subject: Re: [PATCH v8 1/6] software node: rename is_array to is_inline To: Andy Shevchenko Cc: Marek Szyprowski , Dmitry Torokhov , "Rafael J. Wysocki" , Heikki Krogerus , Mika Westerberg , Linus Walleij , Ard Biesheuvel , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver , Linux Samsung SOC , Krzysztof Kozlowski , Felipe Balbi , Linux USB Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 12:28 PM Andy Shevchenko wrote: > > On Thu, Dec 12, 2019 at 12:12:36PM +0100, Marek Szyprowski wrote: > > Dear All, > > > > On 08.11.2019 05:22, Dmitry Torokhov wrote: > > > We do not need a special flag to know if we are dealing with an array, > > > as we can get that data from ratio between element length and the data > > > size, however we do need a flag to know whether the data is stored > > > directly inside property_entry or separately. > > > > > > Signed-off-by: Dmitry Torokhov > > > > Today I've noticed that this patch got merged to linux-next as commit > > e6bff4665c595b5a4aff173848851ed49ac3bfad. Sadly it breaks DWC3/xHCI > > driver operation on Samsung Exynos5 SoCs (and probably on other SoCs > > which use DWC3 in host mode too). I get the following errors during boot: > > > > dwc3 12000000.dwc3: failed to add properties to xHCI > > dwc3 12000000.dwc3: failed to initialize host > > dwc3: probe of 12000000.dwc3 failed with error -61 > > > > Here is a full kernel log from Exynos5250-based Snow Chromebook on KernelCI: > > > > https://storage.kernelci.org/next/master/next-20191212/arm/exynos_defconfig/gcc-8/lab-collabora/boot-exynos5250-snow.txt > > > > (lack of 'ref' clk is not related nor fatal to the driver operation). > > > > The code which fails after this patch is located in > > drivers/usb/dwc3/host.c. Let me know if I can help more in locating the bug. > > Thank you for report. > > I think we should not have that patch in the fist place... I used to have > a bad feeling about it and then forgot about it existence. Well, I think you mean the [2/6]. The $subject one really shouldn't change functionality, we must have missed something here. Anyway, I'll drop this branch from the linux-next one for now.