From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932572AbdJ3KTL (ORCPT ); Mon, 30 Oct 2017 06:19:11 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:47837 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbdJ3KTJ (ORCPT ); Mon, 30 Oct 2017 06:19:09 -0400 X-Google-Smtp-Source: ABhQp+T/0+Y9DCOCWy8UCuZDxuwqa0CeOW7tdj5XWKY7eQbcwQsLfnOA+HP/ERHc4veiX0mHkaWi0IS4Ff9n9uzp4kE= MIME-Version: 1.0 In-Reply-To: <1509347446-26105-1-git-send-email-t-kristo@ti.com> References: <1509347446-26105-1-git-send-email-t-kristo@ti.com> From: "Rafael J. Wysocki" Date: Mon, 30 Oct 2017 11:19:08 +0100 X-Google-Sender-Auth: Iomj1V93NQf5BKlyUwLxPsiTEDg Message-ID: Subject: Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency To: Tero Kristo Cc: Linux PM , Linux Kernel Mailing List , Rafael Wysocki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 30, 2017 at 8:10 AM, Tero Kristo wrote: > The recent change to the PM QoS framework to introduce a proper > no constraint value overlooked to handle the devices which don't > implement PM QoS OPS. Runtime PM is one of the more severely > impacted subsystems, failing every attempt to runtime suspend > a device. This leads into some nasty second level issues like > probe failures and increased power consumption among other things. Oh, that's bad. Sorry about breaking it and thanks for the fix! > Fix this by adding a proper return value for devices that don't > implement PM QoS implicitly. > > Fixes: 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS") > Signed-off-by: Tero Kristo > Cc: Rafael J. Wysocki Applied. > --- > include/linux/pm_qos.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h > index 6737a8c..d68b056 100644 > --- a/include/linux/pm_qos.h > +++ b/include/linux/pm_qos.h > @@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_flags(struct device *dev) > static inline s32 dev_pm_qos_raw_read_value(struct device *dev) > { > return IS_ERR_OR_NULL(dev->power.qos) ? > - 0 : pm_qos_read_value(&dev->power.qos->resume_latency); > + PM_QOS_RESUME_LATENCY_NO_CONSTRAINT : > + pm_qos_read_value(&dev->power.qos->resume_latency); > } > #else > static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, > -- > 1.9.1 > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki