From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Robert Moore <robert.moore@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lv Zheng <lv.zheng@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Emese Revfy <re.emese@gmail.com>,
"devel@acpica.org" <devel@acpica.org>
Subject: Re: [PATCH] acpi: Fix format string type mistakes
Date: Sat, 17 Dec 2016 03:12:17 +0100 [thread overview]
Message-ID: <CAJZ5v0i=+MW4dCFWTgsmQWOj0+rETz9ry3tmDCjhcZGXgphfZg@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jKc35OzaPCR-f34THEkmE4ZbPP-cW2BVFzTgPYVmT_5dw@mail.gmail.com>
On Sat, Dec 17, 2016 at 12:04 AM, Kees Cook <keescook@chromium.org> wrote:
> On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
>> On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook <keescook@chromium.org> wrote:
>>> From: Emese Revfy <re.emese@gmail.com>
>>>
>>> This adds the missing __printf attribute which allows compile time
>>> format string checking (and will be used by the coming initify gcc
>>> plugin). Additionally, this fixes the warnings exposed by the attribute.
>>>
>>> Signed-off-by: Emese Revfy <re.emese@gmail.com>
>>> [kees: split scsi/acpi, merged attr and fix, new commit messages]
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>
>> This modifies code that we get from an external projiect (ACPICA) and
>> the bugs should be fixed in there in the first place.
>
> Who should get CCed?
Fortunately, the right people are in the CC list already. :-)
>> Moreover, I'm not sure if adding __printf in acpiosxf.h is a good idea.
>
> Why not?
Because it would cause that file to diverge from its upstream
counterpart which would be sort of a problem.
> This is going to be needed by the initify plugin to do
> correct detection of what's being passed around to functions...
I guess the question is what we will miss if we don't do that
specifically for ACPICA.
Thanks,
Rafael
next prev parent reply other threads:[~2016-12-17 2:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 21:51 [PATCH] acpi: Fix format string type mistakes Kees Cook
2016-12-16 22:36 ` Rafael J. Wysocki
2016-12-16 23:04 ` Kees Cook
2016-12-17 2:12 ` Rafael J. Wysocki [this message]
2016-12-19 21:45 ` Moore, Robert
2016-12-19 6:05 ` Zheng, Lv
2016-12-21 7:39 ` Zheng, Lv
2016-12-21 8:06 ` Zheng, Lv
2016-12-21 17:16 ` Moore, Robert
2016-12-22 6:52 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0i=+MW4dCFWTgsmQWOj0+rETz9ry3tmDCjhcZGXgphfZg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=devel@acpica.org \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=re.emese@gmail.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).