From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 138C4C4320A for ; Thu, 26 Aug 2021 16:56:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F12C960F42 for ; Thu, 26 Aug 2021 16:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243129AbhHZQ5T (ORCPT ); Thu, 26 Aug 2021 12:57:19 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:34488 "EHLO mail-oi1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbhHZQ5Q (ORCPT ); Thu, 26 Aug 2021 12:57:16 -0400 Received: by mail-oi1-f172.google.com with SMTP id p2so5815608oif.1; Thu, 26 Aug 2021 09:56:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aEqFS/K0D6MKonUszeXgYkQW/P+ojBg3zSOvFVqTnVQ=; b=WqYGdIvGqxGy9QOekRxxlB5XPEADkM1SPP/qCGTZ1dTT+X7+X0zVNlKAqeQSHulOwO QWBBEuCSYNpxlhh9aR5uING6FA1S0cPLP/f3FflnlPfhDEeyTmv5Wh+kkLuxP4i5GL4n k3GtmVGQT1BUbv0ei1e305asyr+eebzzLOzuRe+kGVmUJRZtYU3PSXP7fS/Mvdrpqf8X eSpV+AB/4wwtmbsWYsMaJLKpbFGfBK6DPVLOhCRGG92bRFicUiTyGgnYxT9zkQqSpOu/ 3RFlv+fa9VyUoR13U2rXy2LTW2FS6EcqHMZ5kpi4lhQt/MArgXdxdlDb5ixqFJHYImqM /WXw== X-Gm-Message-State: AOAM531tnL++cC2udeWtVMSoW6p1/olo1+mnKRNBJpFDAQm/FCCoK5h/ 6H+Bnh4NZqoTDXnJx9GIzgfOt8AMOgrc+0NZWAI= X-Google-Smtp-Source: ABdhPJwRJe/paZN6NxlyGl18naa21mDoNn5kPgiY+5253spUxOlG+BuxUwTtUlcEOZo1La9gwdN4ZOKAoo78rWLDg9k= X-Received: by 2002:aca:afcd:: with SMTP id y196mr3197870oie.71.1629996988999; Thu, 26 Aug 2021 09:56:28 -0700 (PDT) MIME-Version: 1.0 References: <20210826105324.36853-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210826105324.36853-1-andriy.shevchenko@linux.intel.com> From: "Rafael J. Wysocki" Date: Thu, 26 Aug 2021 18:56:18 +0200 Message-ID: Subject: Re: [PATCH v2 1/1] media: ipu3-cio2: Drop reference on error path in cio2_bridge_connect_sensor() To: Andy Shevchenko Cc: Daniel Scally , Linux Media Mailing List , Linux Kernel Mailing List , ACPI Devel Maling List , Yong Zhi , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , "Rafael J. Wysocki" , Jens Axboe Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 26, 2021 at 12:53 PM Andy Shevchenko wrote: > > The commit 71f642833284 ("ACPI: utils: Fix reference counting in > for_each_acpi_dev_match()") moved adev assignment outside of error > path and hence made acpi_dev_put(sensor->adev) a no-op. We still > need to drop reference count on error path, and to achieve that, > replace sensor->adev by locally assigned adev. > > Fixes: 71f642833284 ("ACPI: utils: Fix reference counting in for_each_acpi_dev_match()") > Depends-on: fc68f42aa737 ("ACPI: fix NULL pointer dereference") > Reported-by: Jens Axboe > Signed-off-by: Andy Shevchenko > Acked-by: Sakari Ailus > --- > v2: added tag (Sakari), Cc'ed to Rafael to pick up (would be nice to push it to v5.14) > drivers/media/pci/intel/ipu3/cio2-bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c > index 59a36f922675..30d29b96a339 100644 > --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c > +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c > @@ -226,7 +226,7 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, > err_free_swnodes: > software_node_unregister_nodes(sensor->swnodes); > err_put_adev: > - acpi_dev_put(sensor->adev); > + acpi_dev_put(adev); > return ret; > } > > -- Applied as 5.14-rc material, thanks!