From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Jinchao Wang <wjc@cdjrlc.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpuidle: moved EXPORT_SYMBOL so that it immediately followed its function/variable
Date: Wed, 30 Jun 2021 19:38:46 +0200 [thread overview]
Message-ID: <CAJZ5v0iJ6Zo9k3A_4sMBxcNZVB0M1+qTcbrsbQ63-M5OZSGSdg@mail.gmail.com> (raw)
In-Reply-To: <20210623092545.20675-1-wjc@cdjrlc.com>
On Wed, Jun 23, 2021 at 11:26 AM Jinchao Wang <wjc@cdjrlc.com> wrote:
>
> change made to resolve following checkpatch message:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its
> function/variable
checkpatch errors regarding the existing code base are not relevant as a rule.
Now, this patch removes unnecessary empty lines, so it is not
meritless, but it should go under a different subject and with a
changelog describing what's going on.
Something like
Subject: [PATCH] cpuidle: Remove unnecessary empty lines preceding
EXPORT_SYMBOL_GPL()
In several places in cpuidle.c there are empty lines between the
definition of a function and the following EXPORT_SYMBOL_GPL() which
are not necessary, so remove them.
> Signed-off-by: Jinchao Wang <wjc@cdjrlc.com>
> ---
> drivers/cpuidle/cpuidle.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index ef2ea1b12cd8..ddd11236a0cc 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -457,7 +457,6 @@ void cpuidle_pause_and_lock(void)
> mutex_lock(&cpuidle_lock);
> cpuidle_uninstall_idle_handler();
> }
> -
> EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
>
> /**
> @@ -468,7 +467,6 @@ void cpuidle_resume_and_unlock(void)
> cpuidle_install_idle_handler();
> mutex_unlock(&cpuidle_lock);
> }
> -
> EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
>
> /* Currently used in suspend/resume path to suspend cpuidle */
> @@ -538,7 +536,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
>
> return ret;
> }
> -
> EXPORT_SYMBOL_GPL(cpuidle_enable_device);
>
> /**
> @@ -566,7 +563,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
> cpuidle_remove_device_sysfs(dev);
> enabled_devices--;
> }
> -
> EXPORT_SYMBOL_GPL(cpuidle_disable_device);
>
> static void __cpuidle_unregister_device(struct cpuidle_device *dev)
> @@ -665,7 +661,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
> __cpuidle_unregister_device(dev);
> goto out_unlock;
> }
> -
> EXPORT_SYMBOL_GPL(cpuidle_register_device);
>
> /**
> @@ -689,7 +684,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
>
> cpuidle_resume_and_unlock();
> }
> -
> EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
>
> /**
> --
> 2.31.1
>
>
>
parent reply other threads:[~2021-06-30 17:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210623092545.20675-1-wjc@cdjrlc.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0iJ6Zo9k3A_4sMBxcNZVB0M1+qTcbrsbQ63-M5OZSGSdg@mail.gmail.com \
--to=rafael@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wjc@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).