From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942900AbcJSOmX (ORCPT ); Wed, 19 Oct 2016 10:42:23 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:34726 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942448AbcJSOmU (ORCPT ); Wed, 19 Oct 2016 10:42:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <27296716.H9VWo8ShOm@vostro.rjw.lan> <13957403.ZrB4mMbICz@vostro.rjw.lan> From: "Rafael J. Wysocki" Date: Wed, 19 Oct 2016 13:57:12 +0200 X-Google-Sender-Auth: TaGAfK8t9F_bglPmUm-KwLhtf-o Message-ID: Subject: Re: [PATCH v5 0/5] Functional dependencies between devices To: Marek Szyprowski Cc: "Rafael J. Wysocki" , Linux PM list , Greg Kroah-Hartman , Alan Stern , Linux Kernel Mailing List , Tomeu Vizoso , Mark Brown , Lukas Wunner , Kevin Hilman , Ulf Hansson , "Luis R. Rodriguez" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2016 at 12:46 PM, Marek Szyprowski wrote: > Hi Rafael, > > > On 2016-10-10 14:36, Rafael J. Wysocki wrote: >> >> [...] >> >> One more update after some conversations during LinuxCon Europe. >> >> The main point was to make it possible for device_link_add() to figure out >> the >> initial state of the link instead of expecting the caller to provide it >> which >> might not be reliable enough in general. >> >> In this version device_link_add() takes three arguments, the supplier and >> consumer pointers and flags and it sets the correct initial state of the >> link >> automatically (unless invoked with the "stateless" flag, of course). The >> cost >> is one additional field in struct device (I moved all of the links-related >> fields in struct device to a separate sub-structure while at it) to track >> the "driver presence status" of the device (to be used by >> device_link_add()). >> >> In addition to that, the links list walks in the core.c and dd.c code are >> under the device links mutex now, so the iternal link spinlock is not >> needed >> any more and I have renamed symbols to distinguish between flags, link >> states >> and device "driver presence statuses". >> >> More information is there in the changelogs. > > > Thanks for the update. This version is indeed easier to use and still works > fine > with my Exynos IOMMU runtime pm rework. You can keep my: > > Tested-by: Marek Szyprowski > > I will send updated version of my patchset soon. Thanks for the testing, much appreciated! The series is in a new branch called "device-links-test" in my tree now: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git device-links-test Thanks, Rafael