From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E0FC48BDF for ; Thu, 10 Jun 2021 12:31:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A955461403 for ; Thu, 10 Jun 2021 12:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbhFJMc7 (ORCPT ); Thu, 10 Jun 2021 08:32:59 -0400 Received: from mail-oi1-f175.google.com ([209.85.167.175]:37514 "EHLO mail-oi1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbhFJMcx (ORCPT ); Thu, 10 Jun 2021 08:32:53 -0400 Received: by mail-oi1-f175.google.com with SMTP id h9so1930911oih.4; Thu, 10 Jun 2021 05:30:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MuzNL7tfDK7e4h6RLyE9IdnW6BdejixhbQSLxfkQyeY=; b=MOXKVL/gm7ShmNXGXhm69v7zjS/T3B0BFfCaLfJLWOPrAFskxDACWivteA5mj4yVEx 7Wub/sIkUoUBtQbdM2qUWHQZ8gRp3WtXagTyFHz4fhPGxCy31DTqjdL9hMBTpMkHf2ce 67NtFcxQynsqLoHXweZLdGpPIaC68te2oTP6w0+0WTNG4azzz9rDsLzen0i4HcDcOvuZ E51n1DuZHgH9NmyZREfp7JWLmvrqNgasIzvp/31JUrJKoKAkG/3qUZXRXLKC4SvOK9z2 t7BaVevhy2DDl/uLIhcgBaemzZ6kqyWQ6KXXIZv4DaBSf2mRJPJhnBd7TRdM6/tC4VjS w/hA== X-Gm-Message-State: AOAM5336ccHWaX6CGMf4Wvb3IxDgNGZWonvf4yeLKwjFrGaEeHZpDGQ6 +CK9fcOmpGKLJfXKevWxqPmM8ouiCUFRSmO4qi/6VMQy X-Google-Smtp-Source: ABdhPJwwCBUE8fN+1yyMTDGiGyvEZbldVa9b+ODFBClXQ+w2/+StudMLj/LRVSI+DNBCJIwLKCZz3ybN6Ur8WtSp1Pk= X-Received: by 2002:a05:6808:f08:: with SMTP id m8mr210416oiw.69.1623328240475; Thu, 10 Jun 2021 05:30:40 -0700 (PDT) MIME-Version: 1.0 References: <28308fc0d38f252baf90e6ffb31fd2f8660be273.1623311808.git.viresh.kumar@linaro.org> <20210610113359.gb2cu3miwuo44d5b@vireshk-i7> In-Reply-To: <20210610113359.gb2cu3miwuo44d5b@vireshk-i7> From: "Rafael J. Wysocki" Date: Thu, 10 Jun 2021 14:30:29 +0200 Message-ID: Subject: Re: [PATCH] cpufreq: cppc: Mark frequency invariance broken To: Viresh Kumar Cc: "Rafael J. Wysocki" , Rafael Wysocki , Ionela Voinescu , Linux PM , Vincent Guittot , Qian Cai , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 1:34 PM Viresh Kumar wrote: > > On 10-06-21, 13:19, Rafael J. Wysocki wrote: > > On Thu, Jun 10, 2021 at 9:58 AM Viresh Kumar wrote: > > > > > > There are few races in the frequency invariance support for CPPC driver, > > > namely the driver doesn't stop the kthread_work and irq_work on policy > > > exit during suspend/resume or CPU hotplug. > > > > > > A proper fix won't be possible for the 5.13-rc, as it requires a lot of > > > changes. Instead of reverting the patch, mark this feature BROKEN for > > > now. > > > > > > Fixes: 4c38f2df71c8 ("cpufreq: CPPC: Add support for frequency invariance") > > > Reported-by: Qian Cai > > > Signed-off-by: Viresh Kumar > > > > Well, why don't we revert 4c38f2df71c8 instead? > > > > Is there any particular reason for retaining it? > > I was just trying to reduce the diff size here, since this feature > (which broke) was controlled by a CONFIG option, it looked like a nice > way of doing it. > > It was already reviewed and a diff over it should be easier to review. > > I can do a full revert if that's what you want. I would prefer a full revert TBH. Making a new feature depend on BROKEN feels like it shouldn't have been added at this point in the first place.