From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D04CC55179 for ; Thu, 22 Oct 2020 16:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D55EB22267 for ; Thu, 22 Oct 2020 16:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603385319; bh=ck6/lrSBrQex3J2r524MHaRoj9WCg2vIcLo5lSugLTg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=UnTYa7cFEcW4ED4ojpvaV3rMH7t+10c+fJLJD/GhUMQxjnQ2o5Tu5eFhgQpUDNK+M cf885W0MrGklz8enXrf1+N+H//7XL3XRUC9ygNOrb7su2jvf7FJN0lBomIvNhP3+9D kjZTFbOo0ycb2WV1ZR4bPqBjti1gFv+3n528Ea5c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2898083AbgJVQsj (ORCPT ); Thu, 22 Oct 2020 12:48:39 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:36207 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898044AbgJVQsi (ORCPT ); Thu, 22 Oct 2020 12:48:38 -0400 Received: by mail-oi1-f193.google.com with SMTP id u17so2426887oie.3; Thu, 22 Oct 2020 09:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lvu53nwOmKW1a9CIVBFMcps6EWS89y5EclPDxC9nmh0=; b=AWISSvatpQRlrh3PzPaZPP6b1DWGwzTfz93WZnRJCK5PgkRczrCac4MDrPLwtjarc7 tlJiIdUjOWVEzdv6g5jMhP/7mTyhOg4Xlo7xudlYOj3vGdH9twPaUydOHWxJWfmZXT0Y 4T81UbXKLhj+Pr+vzPe8TPo9p/PXbPj4SaCusshStz6KQU/KXsxGHRWD36FxLi+gzj1H HJX/T58NzLoHIGuRLSwG8WpgW0Jd/MIiTSiQUhek4RvlFSiv5FMO5EaWl9c+0mcXbQ0Z o7iy8FJgOkJ/VzDv0RkfY+hA9N1jiJI9RGfv5B/q0H6MBMOZP7sro8wq967EVLegP7Ap PNoA== X-Gm-Message-State: AOAM530U9pLQBVJi7Qu7sMaWPm0VJJ12EGprSMusd/Kcfxhi8hwXX+h5 Bpv4z46AASMi5K9RK2GqRKyUhd/Vz5UH518TkuU= X-Google-Smtp-Source: ABdhPJxhcIWseF3yHvWk8TdYgm957ZVABMLlalztBBNEBhcFWBGwcc0wbNMHAd+rBk4ySn8nYVYklgvsrFCkcQAIc8o= X-Received: by 2002:aca:fd52:: with SMTP id b79mr2204257oii.69.1603385317918; Thu, 22 Oct 2020 09:48:37 -0700 (PDT) MIME-Version: 1.0 References: <20201019200330.16629-1-trix@redhat.com> In-Reply-To: <20201019200330.16629-1-trix@redhat.com> From: "Rafael J. Wysocki" Date: Thu, 22 Oct 2020 18:48:26 +0200 Message-ID: Subject: Re: [PATCH] PM: sleep: remove unneeded break To: trix@redhat.com Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Linux PM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2020 at 10:03 PM wrote: > > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix > --- > drivers/base/power/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index 205a06752ca9..c7ac49042cee 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -363,7 +363,6 @@ static pm_callback_t pm_op(const struct dev_pm_ops *ops, pm_message_t state) > case PM_EVENT_THAW: > case PM_EVENT_RECOVER: > return ops->thaw; > - break; > case PM_EVENT_RESTORE: > return ops->restore; > #endif /* CONFIG_HIBERNATE_CALLBACKS */ > -- Applied as 5.10-rc material with edits in the subject and changelog, thanks!