From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Thomas Hänig" <haenig@cosifan.de>
Cc: Takashi Iwai <tiwai@suse.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Erik Schmauss <erik.schmauss@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: [REGRESSION 4.17] Spurious wakeup / reboot with power button
Date: Sun, 8 Jul 2018 10:18:22 +0200 [thread overview]
Message-ID: <CAJZ5v0ipP8JP01L7E4FwL1K6woda4oBKMxgLRfOiNYujzoY37w@mail.gmail.com> (raw)
In-Reply-To: <c04bb990-8921-90c5-e298-bf68e3c9cd33@cosifan.de>
On Fri, Jul 6, 2018 at 7:57 PM, Thomas Hänig <haenig@cosifan.de> wrote:
>
>
> Am 06.07.2018 um 14:27 schrieb Takashi Iwai:
>> On Fri, 06 Jul 2018 14:13:04 +0200,
>> Rafael J. Wysocki wrote:
>>>
>>> On Friday, July 6, 2018 1:21:50 PM CEST Rafael J. Wysocki wrote:
>>>> On Fri, Jul 6, 2018 at 1:12 PM, Thomas Hänig <haenig@cosifan.de> wrote:
>>>
>>> [cut]
>>>
>>>> So the latest patch:
>>>>
>>>> https://patchwork.kernel.org/patch/10511211/
>>>>
>>>> should work for you (please verify) and the change in
>>>> drivers/acpi/sleep.c in it most likely is not necessary.
>>>>
>>>> If you can confirm that this one works for you, I'll send a smaller
>>>> one with the acpi_hw_legacy_sleep() part alone.
>>>
>>> Well, scratch this, sorry.
>>>
>>> The power button probably is a fixed event and it won't be effected by
>>> that patch.
>>>
>>> Instead, please test the patch below.
>>
>> FWIW, the test kernel on OBS home:tiwai:bsc1099930-3 was refreshed
>> with this one. The release number will be *.g2351e2d.
>>
>>
>> Takashi
>>
>>>
>>> ---
>>> drivers/acpi/acpica/hwsleep.c | 15 +++++++++++----
>>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>>
>>> Index: linux-pm/drivers/acpi/acpica/hwsleep.c
>>> ===================================================================
>>> --- linux-pm.orig/drivers/acpi/acpica/hwsleep.c
>>> +++ linux-pm/drivers/acpi/acpica/hwsleep.c
>>> @@ -51,16 +51,23 @@ acpi_status acpi_hw_legacy_sleep(u8 slee
>>> return_ACPI_STATUS(status);
>>> }
>>>
>>> - /*
>>> - * 1) Disable all GPEs
>>> - * 2) Enable all wakeup GPEs
>>> - */
>>> + /* Disable all GPEs */
>>> status = acpi_hw_disable_all_gpes();
>>> if (ACPI_FAILURE(status)) {
>>> return_ACPI_STATUS(status);
>>> }
>>> + /*
>>> + * If the target sleep state is S5, clear all GPEs and fixed events too
>>> + */
>>> + if (sleep_state == ACPI_STATE_S5) {
>>> + status = acpi_hw_clear_acpi_status();
>>> + if (ACPI_FAILURE(status)) {
>>> + return_ACPI_STATUS(status);
>>> + }
>>> + }
>>> acpi_gbl_system_awake_and_running = FALSE;
>>>
>>> + /* Enable all wakeup GPEs */
>>> status = acpi_hw_enable_all_wakeup_gpes();
>>> if (ACPI_FAILURE(status)) {
>>> return_ACPI_STATUS(status);
>>>
> Hello Takashi,
> with the kernel built by you the system shuts down when pressing the
> power button and stays off too! :-)
>
> So the above mentioned patch to hwsleep.c seems to do the trick.
OK, thanks for verifying!
> Regards and thanks a lot @all!
Cheers,
Rafael
next prev parent reply other threads:[~2018-07-08 8:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 7:05 [REGRESSION 4.17] Spurious wakeup / reboot with power button Takashi Iwai
2018-07-05 9:34 ` Rafael J. Wysocki
2018-07-05 9:50 ` Takashi Iwai
2018-07-05 9:58 ` Thomas Hänig
2018-07-05 10:00 ` Takashi Iwai
2018-07-05 10:16 ` Rafael J. Wysocki
2018-07-05 10:41 ` Rafael J. Wysocki
2018-07-05 12:12 ` Takashi Iwai
2018-07-05 12:19 ` Thomas Hänig
2018-07-05 14:00 ` Thomas Hänig
2018-07-05 15:09 ` Takashi Iwai
2018-07-05 15:10 ` Rafael J. Wysocki
2018-07-05 16:02 ` Rafael J. Wysocki
2018-07-05 16:56 ` Takashi Iwai
2018-07-05 18:18 ` Thomas Hänig
2018-07-06 5:18 ` Thomas Hänig
2018-07-06 6:55 ` Takashi Iwai
2018-07-06 9:40 ` Rafael J. Wysocki
2018-07-06 9:53 ` Takashi Iwai
2018-07-06 11:12 ` Thomas Hänig
2018-07-06 11:21 ` Rafael J. Wysocki
2018-07-06 12:13 ` Rafael J. Wysocki
2018-07-06 12:27 ` Takashi Iwai
2018-07-06 12:53 ` Thomas Hänig
2018-07-06 17:57 ` Thomas Hänig
2018-07-08 8:18 ` Rafael J. Wysocki [this message]
2018-07-06 12:49 ` Thomas Hänig
2018-07-08 9:10 ` [PATCH] ACPICA: Clear status of all events when entering S5 Rafael J. Wysocki
2018-07-16 17:59 ` Schmauss, Erik
2018-07-17 7:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0ipP8JP01L7E4FwL1K6woda4oBKMxgLRfOiNYujzoY37w@mail.gmail.com \
--to=rafael@kernel.org \
--cc=erik.schmauss@intel.com \
--cc=haenig@cosifan.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).