From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mathew King <mathewk@chromium.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] acpi: battery: Always read fresh battery state on update
Date: Fri, 5 Jun 2020 13:30:13 +0200 [thread overview]
Message-ID: <CAJZ5v0iteOV=4CnQrVx5ZmnWq5Uf88k7UMMmKcMxgJnco3kxvg@mail.gmail.com> (raw)
In-Reply-To: <20200604195658.66201-1-mathewk@chromium.org>
On Thu, Jun 4, 2020 at 9:57 PM Mathew King <mathewk@chromium.org> wrote:
>
> When the ACPI battery receives a notification event it should always
> read the battery state fresh from the ACPI device and not use the cached
> state.
Why should it?
> Currently the cached state stays valid and the new state may not
> be read when a notification occurs. This can lead to a udev event
> showing that the battery has changed but the sysfs state will still have
> the cached state values.
Is there a bug entry or similar related to that which can be referred
to from this patch?
> This change invalidates the update time forcing
> the state to be updated before notifying the power_supply subsystem of
> the change.
>
> Signed-off-by: Mathew King <mathewk@chromium.org>
> ---
> drivers/acpi/battery.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 366c389175d8..ab7fa4879fbe 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -981,6 +981,7 @@ static int acpi_battery_update(struct acpi_battery *battery, bool resume)
> acpi_battery_init_alarm(battery);
> }
>
> + battery->update_time = 0;
AFAICS this is equivalent to dropping battery->update_time altogether.
Isn't that a bit too excessive?
> result = acpi_battery_get_state(battery);
> if (result)
> return result;
> --
next prev parent reply other threads:[~2020-06-05 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 19:56 [PATCH] acpi: battery: Always read fresh battery state on update Mathew King
2020-06-05 11:30 ` Rafael J. Wysocki [this message]
2020-06-05 18:01 ` Mat King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0iteOV=4CnQrVx5ZmnWq5Uf88k7UMMmKcMxgJnco3kxvg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathewk@chromium.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).