From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM list <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Mark Brown <broonie@kernel.org>, Lukas Wunner <lukas@wunner.de>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH v5 0/5] Functional dependencies between devices
Date: Thu, 20 Oct 2016 14:54:56 +0200 [thread overview]
Message-ID: <CAJZ5v0ivT5eAPvg_NWtU+o0GrghwJMEdvPiLxt8m3C6BU5=nrw@mail.gmail.com> (raw)
In-Reply-To: <a49cc8aa-84fe-5752-efdc-113a116e588d@samsung.com>
Hi,
On Thu, Oct 20, 2016 at 12:21 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Hi Rafael,
>
>
> On 2016-10-19 13:57, Rafael J. Wysocki wrote:
>>
>> On Tue, Oct 18, 2016 at 12:46 PM, Marek Szyprowski
>> <m.szyprowski@samsung.com> wrote:
>>>
>>> On 2016-10-10 14:36, Rafael J. Wysocki wrote:
>>>>
>>>> [...]
>>>>
>>>> One more update after some conversations during LinuxCon Europe.
>>>>
>>>> The main point was to make it possible for device_link_add() to figure
>>>> out
>>>> the
>>>> initial state of the link instead of expecting the caller to provide it
>>>> which
>>>> might not be reliable enough in general.
>>>>
>>>> In this version device_link_add() takes three arguments, the supplier
>>>> and
>>>> consumer pointers and flags and it sets the correct initial state of the
>>>> link
>>>> automatically (unless invoked with the "stateless" flag, of course).
>>>> The
>>>> cost
>>>> is one additional field in struct device (I moved all of the
>>>> links-related
>>>> fields in struct device to a separate sub-structure while at it) to
>>>> track
>>>> the "driver presence status" of the device (to be used by
>>>> device_link_add()).
>>>>
>>>> In addition to that, the links list walks in the core.c and dd.c code
>>>> are
>>>> under the device links mutex now, so the iternal link spinlock is not
>>>> needed
>>>> any more and I have renamed symbols to distinguish between flags, link
>>>> states
>>>> and device "driver presence statuses".
>>>>
>>>> More information is there in the changelogs.
>>>
>>> Thanks for the update. This version is indeed easier to use and still
>>> works
>>> fine
>>> with my Exynos IOMMU runtime pm rework. You can keep my:
>>>
>>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>>
>>> I will send updated version of my patchset soon.
>>
>> Thanks for the testing, much appreciated!
>>
>> The series is in a new branch called "device-links-test" in my tree now:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
>> device-links-test
>
>
> While working on integrating IOMMU deferred probing patches I found a bug,
> which has been introduced in v4 of device dependency patchset (v3 worked
> fine in this area, v5 also contains this bug). The following fixup is
> needed to properly create links with DL_FLAG_PM_RUNTIME flag set during
> consumer device probing:
>
> From: Marek Szyprowski <m.szyprowski@samsung.com>
> Date: Thu, 20 Oct 2016 12:12:14 +0200
> Subject: [PATCH] driver core: fix runtime pm state for
> DEVICE_LINK_CONSUMER_PROBE links
>
> If link is added during consumer probe with DL_FLAG_PM_RUNTIME flag set,
> the code will do additional pm_runtime_put() on the supplier after
> finishing consumer probing. This will break runtime pm operation for
> the supplier device. To solve this issue, enforce additional call to
> pm_runtime_get_sync() on the supplier device while creating such link.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/base/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 48bc5a362f7d..d4cc285a1df7 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -217,6 +217,9 @@ struct device_link *device_link_add(struct device
> *consumer,
> }
> }
>
> + if (flags & DL_FLAG_PM_RUNTIME && status == DL_STATE_CONSUMER_PROBE)
> + pm_runtime_get_sync(supplier);
> +
Good catch!
I'd prefer to do this slightly differently, though, so I'll send an
update of the runtime PM patch with this folded in shortly.
Thanks,
Rafael
next prev parent reply other threads:[~2016-10-20 12:55 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 21:25 [RFC/RFT][PATCH v2 0/7] Functional dependencies between devices Rafael J. Wysocki
2016-09-08 21:26 ` [RFC/RFT][PATCH v2 1/7] driver core: Add a wrapper around __device_release_driver() Rafael J. Wysocki
2016-09-08 21:27 ` [RFC/RFT][PATCH v2 2/7] driver core: Functional dependencies tracking support Rafael J. Wysocki
2016-09-09 8:25 ` Ulf Hansson
2016-09-09 12:06 ` Mark Brown
2016-09-09 14:13 ` Ulf Hansson
2016-09-15 1:11 ` Rafael J. Wysocki
2016-09-11 13:40 ` Lukas Wunner
2016-09-11 20:43 ` Lukas Wunner
2016-09-14 1:21 ` Rafael J. Wysocki
2016-09-14 8:28 ` Lukas Wunner
2016-09-14 13:17 ` Rafael J. Wysocki
2016-09-08 21:28 ` [RFC/RFT][PATCH v2 3/7] PM / sleep: Make async suspend/resume of devices use device links Rafael J. Wysocki
2016-09-10 13:31 ` Lukas Wunner
2016-09-10 22:12 ` Rafael J. Wysocki
2016-09-08 21:29 ` [RFC/RFT][PATCH v2 4/7] PM / runtime: Pass flags argument to __pm_runtime_disable() Rafael J. Wysocki
2016-09-08 21:29 ` [RFC/RFT][PATCH v2 5/7] PM / runtime: Flag to indicate PM sleep transitions in progress Rafael J. Wysocki
2016-09-12 14:07 ` Lukas Wunner
2016-09-12 21:25 ` Rafael J. Wysocki
2016-09-12 22:52 ` Lukas Wunner
2016-09-13 7:21 ` Marek Szyprowski
2016-09-13 23:59 ` Rafael J. Wysocki
2016-09-08 21:30 ` [RFC/RFT][PATCH v2 6/7] PM / runtime: Use device links Rafael J. Wysocki
2016-09-12 9:47 ` Lukas Wunner
2016-09-12 13:57 ` Rafael J. Wysocki
2016-09-14 1:19 ` Rafael J. Wysocki
2016-09-08 21:31 ` [RFC/RFT][PATCH v2 7/7] PM / runtime: Optimize the use of " Rafael J. Wysocki
2016-09-08 21:35 ` [RFC/RFT][PATCH v2 0/7] Functional dependencies between devices Rafael J. Wysocki
2016-09-10 11:39 ` Lukas Wunner
2016-09-10 22:04 ` Rafael J. Wysocki
2016-09-13 17:57 ` Lukas Wunner
2016-09-13 23:18 ` Rafael J. Wysocki
2016-09-18 12:39 ` Lukas Wunner
[not found] ` <CGME20160913095858eucas1p267ec2397c9e4577f94557e4a38498164@eucas1p2.samsung.com>
2016-09-13 9:58 ` Marek Szyprowski
2016-09-13 22:41 ` Rafael J. Wysocki
2016-09-18 11:23 ` Lukas Wunner
2016-09-15 22:03 ` [RFC/RFT][PATCH v3 0/5] " Rafael J. Wysocki
2016-09-15 22:04 ` [Resend][RFC/RFT][PATCH v3 1/5] driver core: Add a wrapper around __device_release_driver() Rafael J. Wysocki
2016-09-15 22:06 ` [RFC/RFT][PATCH v3 2/5] driver core: Functional dependencies tracking support Rafael J. Wysocki
2016-09-16 7:53 ` Marek Szyprowski
2016-09-16 12:06 ` Rafael J. Wysocki
2016-09-16 12:33 ` [Update][RFC/RFT][PATCH " Rafael J. Wysocki
2016-09-19 22:46 ` Lukas Wunner
2016-09-23 13:03 ` Lukas Wunner
2016-09-23 13:42 ` Rafael J. Wysocki
2016-09-26 16:51 ` Lukas Wunner
2016-09-27 12:16 ` Rafael J. Wysocki
2016-09-27 8:54 ` Lukas Wunner
2016-09-27 11:52 ` Rafael J. Wysocki
2016-09-28 10:43 ` Lukas Wunner
2016-09-28 11:31 ` Rafael J. Wysocki
2016-09-29 10:36 ` Lukas Wunner
2016-09-15 22:06 ` [RFC/RFT][PATCH v3 3/5] PM / sleep: Make async suspend/resume of devices use device links Rafael J. Wysocki
2016-09-15 22:07 ` [RFC/RFT][PATCH v3 4/5] PM / runtime: Use " Rafael J. Wysocki
2016-09-15 22:07 ` [RFC/RFT][PATCH v3 5/5] PM / runtime: Optimize the use of " Rafael J. Wysocki
2016-09-16 7:25 ` [RFC/RFT][PATCH v3 0/5] Functional dependencies between devices Marek Szyprowski
2016-09-16 7:57 ` Marek Szyprowski
2016-09-16 12:04 ` Rafael J. Wysocki
2016-09-27 12:34 ` Lukas Wunner
2016-09-28 0:33 ` Rafael J. Wysocki
2016-09-28 11:42 ` Lukas Wunner
2016-09-29 0:51 ` Rafael J. Wysocki
2016-11-15 18:50 ` Lukas Wunner
2016-09-29 0:24 ` [PATCH v4 " Rafael J. Wysocki
2016-09-29 0:25 ` [Resend][PATCH v4 1/5] driver core: Add a wrapper around __device_release_driver() Rafael J. Wysocki
2016-09-29 0:38 ` [PATCH v4 2/5] driver core: Functional dependencies tracking support Rafael J. Wysocki
2016-10-01 7:43 ` Lukas Wunner
2016-10-01 23:32 ` Rafael J. Wysocki
2016-09-29 0:38 ` [Resend][PATCH v4 3/5] PM / sleep: Make async suspend/resume of devices use device links Rafael J. Wysocki
2016-09-29 0:40 ` [PATCH v4 4/5] PM / runtime: Use " Rafael J. Wysocki
2016-09-29 0:41 ` [Rebase][PATCH v4 5/5] PM / runtime: Optimize the use of " Rafael J. Wysocki
2016-09-29 6:58 ` [PATCH v4 0/5] Functional dependencies between devices Marek Szyprowski
2016-09-29 12:27 ` Rafael J. Wysocki
2016-10-02 23:13 ` Lukas Wunner
2016-10-10 12:36 ` [PATCH v5 " Rafael J. Wysocki
2016-10-10 12:37 ` [Resend][PATCH v5 1/5] driver core: Add a wrapper around __device_release_driver() Rafael J. Wysocki
2016-10-10 12:51 ` [PATCH v5 2/5] driver core: Functional dependencies tracking support Rafael J. Wysocki
2016-10-26 11:19 ` Lukas Wunner
2016-10-27 15:25 ` Greg Kroah-Hartman
2016-10-28 9:57 ` Lukas Wunner
2016-11-07 21:22 ` Luis R. Rodriguez
2016-11-08 6:45 ` Greg Kroah-Hartman
2016-11-08 19:21 ` Luis R. Rodriguez
2016-11-08 19:43 ` Greg Kroah-Hartman
2016-11-08 20:58 ` Luis R. Rodriguez
2016-11-09 6:45 ` Greg Kroah-Hartman
2016-11-09 9:36 ` Andrzej Hajda
2016-11-09 9:41 ` Greg Kroah-Hartman
2016-11-13 16:58 ` Lukas Wunner
2016-11-10 0:43 ` Rafael J. Wysocki
2016-11-10 0:59 ` Luis R. Rodriguez
2016-11-10 7:14 ` Laurent Pinchart
2016-11-10 22:04 ` Luis R. Rodriguez
2016-11-10 22:40 ` Greg Kroah-Hartman
2016-11-11 0:08 ` Laurent Pinchart
2016-11-13 10:59 ` Greg Kroah-Hartman
2016-11-14 14:50 ` Luis R. Rodriguez
2016-11-14 8:15 ` Geert Uytterhoeven
2016-11-10 8:46 ` Geert Uytterhoeven
2016-11-10 22:12 ` Luis R. Rodriguez
2016-10-27 15:32 ` Greg Kroah-Hartman
2016-11-07 21:39 ` Luis R. Rodriguez
2016-11-10 1:07 ` Rafael J. Wysocki
2016-11-10 7:05 ` Laurent Pinchart
2016-11-10 23:09 ` Luis R. Rodriguez
2016-11-13 17:34 ` Lukas Wunner
2016-11-14 13:48 ` Luis R. Rodriguez
2016-11-14 15:48 ` Lukas Wunner
2016-11-14 16:00 ` Luis R. Rodriguez
2016-10-10 12:54 ` [PATCH v5 3/5] PM / sleep: Make async suspend/resume of devices use device links Rafael J. Wysocki
2016-10-10 12:56 ` [PATCH v5 4/5] PM / runtime: Use " Rafael J. Wysocki
2016-10-20 13:17 ` [Update][PATCH " Rafael J. Wysocki
2016-10-10 12:57 ` [Rebase][PATCH v5 5/5] PM / runtime: Optimize the use of " Rafael J. Wysocki
2016-10-18 10:46 ` [PATCH v5 0/5] Functional dependencies between devices Marek Szyprowski
2016-10-19 11:57 ` Rafael J. Wysocki
2016-10-20 10:21 ` Marek Szyprowski
2016-10-20 12:54 ` Rafael J. Wysocki [this message]
2016-10-27 15:32 ` Greg Kroah-Hartman
[not found] ` <5811F0CF.5000204@huawei.com>
2016-10-28 9:39 ` Lukas Wunner
2016-11-02 20:55 ` Hanjun Guo
2016-10-30 16:22 ` [PATCH v6 " Rafael J. Wysocki
2016-10-30 16:28 ` [Resend][PATCH v6 3/5] PM / sleep: Make async suspend/resume of devices use device links Rafael J. Wysocki
2016-10-30 16:29 ` [Resend][PATCH v6 1/5] driver core: Add a wrapper around __device_release_driver() Rafael J. Wysocki
2016-10-30 16:32 ` [PATCH v6 2/5] driver core: Functional dependencies tracking support Rafael J. Wysocki
2016-10-30 16:32 ` [PATCH v6 4/5] PM / runtime: Use device links Rafael J. Wysocki
2016-12-18 14:01 ` Lukas Wunner
2016-12-18 15:53 ` Rafael J. Wysocki
2016-12-18 16:37 ` Lukas Wunner
2016-12-19 12:38 ` Rafael J. Wysocki
2016-10-30 16:32 ` [Resend][PATCH v6 5/5] PM / runtime: Optimize the use of " Rafael J. Wysocki
2016-10-30 16:40 ` [PATCH v6 0/5] Functional dependencies between devices Rafael J. Wysocki
2016-10-31 17:47 ` Greg Kroah-Hartman
2016-11-01 3:50 ` Rafael J. Wysocki
2016-11-02 7:58 ` Marek Szyprowski
2016-11-05 12:10 ` Greg Kroah-Hartman
2016-11-07 21:15 ` Luis R. Rodriguez
2016-11-08 6:36 ` Marek Szyprowski
2016-11-08 20:14 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0ivT5eAPvg_NWtU+o0GrghwJMEdvPiLxt8m3C6BU5=nrw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=mcgrof@suse.com \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).