From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB20CC43465 for ; Fri, 18 Sep 2020 16:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D112389F for ; Fri, 18 Sep 2020 16:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600444933; bh=uFY2Z4rDMFVgVfrtk/yGyKngm39+CPRRFFq+wyIxitM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=mNLQ8jqu2af4oUT85SuWsnLpBczW+lhS479aLZmOXAjZZOj8eVztvvyZGU1pGrJKx QeFWHa+gPdd1IKxlj5lu1YZe0Mb6jvM1/FDBHUTTBHTd8LSGCir24UJM+AwqbkwFGQ GO9FFQt2FkP07oYKtZfvZrC5qlasCMD43owecu7s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbgIRQCM (ORCPT ); Fri, 18 Sep 2020 12:02:12 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:33602 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbgIRQCL (ORCPT ); Fri, 18 Sep 2020 12:02:11 -0400 Received: by mail-oi1-f196.google.com with SMTP id m7so7616436oie.0; Fri, 18 Sep 2020 09:02:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CLWLadygFzbacUrStlzsUwiQts54prWGYIH+pDEwe0A=; b=dYrQVj2rSXLlWEWNr3I6U+LMUuW6xJDLNKqC4E7FszQEKpmQFodheM4yINYXSj//4h NM1YRX+jum28PBQ41gM6/AMWC6ktoTFS+vbC0ZsBf0C4IZ81/JqC5U2qN3teCiFXUYF5 aMclzO4ylo+9ObumQp7O9zxoLga6nGnBAjVLRmBYZpb/W4WDJqFpCAqekLFudl8uIdrm iZUoM+rZjj0dL8lXgqx86r2BiWszlUMFR0hF+gMXinVjoY1ajYGpU2/qz0vmVrtWtfIe 8vjRzXOjFrQek3EfiMKb3Z/THPKF02ZimCEIjh1aIrjZpTT3i80ps+NArBlU9whzMuCi Hx5A== X-Gm-Message-State: AOAM532srrIyMv6hz9hJYp9Xi/nPRaCXHbVFToX9G1562zLHtuxhlyrr u1M6ZZNVFkSe2LSw/75VDYwvB4h7zT4a159QT1I= X-Google-Smtp-Source: ABdhPJygTxTyjBXaRmjiZjnzUB9+LiiCBE3DDYWxmdEXB/AZO3s12ola6t96FwD5p8jaLrRmcTTRjtSYPzdoh/tzvoc= X-Received: by 2002:aca:df84:: with SMTP id w126mr10401882oig.103.1600444930764; Fri, 18 Sep 2020 09:02:10 -0700 (PDT) MIME-Version: 1.0 References: <20200917165720.3285256-1-hch@lst.de> <20200917165720.3285256-14-hch@lst.de> In-Reply-To: <20200917165720.3285256-14-hch@lst.de> From: "Rafael J. Wysocki" Date: Fri, 18 Sep 2020 18:01:59 +0200 Message-ID: Subject: Re: [PATCH 13/14] PM: mm: cleanup swsusp_swap_check To: Christoph Hellwig Cc: Jens Axboe , Josef Bacik , Minchan Kim , Stefan Haberland , Jan Hoeppner , Joseph Qi , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Andrew Morton , Linux Kernel Mailing List , nbd@other.debian.org, "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Linux PM , Linux Memory Management List , linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 7:39 PM Christoph Hellwig wrote: > > Use blkdev_get_by_dev instead of bdget + blkdev_get. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > kernel/power/swap.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index 9d3ffbfe08dbf6..71385bedcc3a49 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -343,12 +343,10 @@ static int swsusp_swap_check(void) > return res; > root_swap = res; > > - hib_resume_bdev = bdget(swsusp_resume_device); > - if (!hib_resume_bdev) > - return -ENOMEM; > - res = blkdev_get(hib_resume_bdev, FMODE_WRITE, NULL); > - if (res) > - return res; > + hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device, FMODE_WRITE, > + NULL); > + if (IS_ERR(hib_resume_bdev)) > + return PTR_ERR(hib_resume_bdev); > > res = set_blocksize(hib_resume_bdev, PAGE_SIZE); > if (res < 0) > -- > 2.28.0 >