From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: David Laight <David.Laight@aculab.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rajat Jain <rajatja@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
"open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:"
<linux-usb@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
Rajat Jain <rajatxjain@gmail.com>,
Jesse Barnes <jsbarnes@google.com>,
Dmitry Torokhov <dtor@google.com>
Subject: Re: [PATCH v2 2/2] pci: Support "removable" attribute for PCI devices
Date: Wed, 28 Apr 2021 14:21:27 +0200 [thread overview]
Message-ID: <CAJZ5v0jEbjRSGPdfwvegawin5_N=m-UoP+Wa99EQ-QmkusiBCg@mail.gmail.com> (raw)
In-Reply-To: <0601e45130495b152bec04eee4a50e302db4cfd2.camel@suse.com>
On Wed, Apr 28, 2021 at 8:57 AM Oliver Neukum <oneukum@suse.com> wrote:
>
> Am Dienstag, den 27.04.2021, 12:59 +0000 schrieb David Laight:
> > From: Oliver Neukum
> > > Sent: 27 April 2021 13:00
>
> > > that is true for those options, but not for the style
> > > of PCI hotplug which requires you to push a button and wait
> > > for the blinking light.
> >
> > True, I remember some of those PCI hotplug chassis from 25 years ago.
> > ISTR we did get the removal events working (SVR4/Unixware) but I
> > don't remember the relevant chassis ever being sold.
> > In spite of the marketing hype I suspect it was only ever possible
> > to remove a completely working board and replace it with an
> > exactly equivalent one.
> >
> > In any case those chassis are not 'surprise removal'.
> >
> > More modern drivers are less likely to crash (and burn?) when
> > a PCI read returns ~0u.
> > But I suspect an awful lot really don't handle surprise removal
> > very well at all.
>
> So you are saying that these systems are so rare that it should be
> handled as special cases if at all?
In principle, in the wake of Thunderbolt every PCI driver handling
PCIe devices needs to be able to deal with a device that's gone away
without notice, because in principle any PCIe device can be included
into a Thunderbolt docking station which may go away as a whole
without notice.
next prev parent reply other threads:[~2021-04-28 12:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 2:16 [PATCH v2 1/2] driver core: Move the "removable" attribute from USB to core Rajat Jain
2021-04-24 2:16 ` [PATCH v2 2/2] pci: Support "removable" attribute for PCI devices Rajat Jain
2021-04-26 9:17 ` Oliver Neukum
2021-04-26 11:49 ` Rafael J. Wysocki
2021-04-26 13:01 ` David Laight
2021-04-26 19:47 ` Rajat Jain
2021-04-27 11:59 ` Oliver Neukum
2021-04-27 12:59 ` David Laight
2021-04-28 6:56 ` Oliver Neukum
2021-04-28 12:21 ` Rafael J. Wysocki [this message]
2021-04-29 9:03 ` Oliver Neukum
2021-04-29 9:57 ` Rafael J. Wysocki
2021-04-29 16:59 ` Rajat Jain
2021-05-11 21:30 ` Bjorn Helgaas
2021-05-11 22:15 ` Rajat Jain
2021-05-11 23:02 ` Bjorn Helgaas
2021-05-12 0:02 ` Rajat Jain
2021-05-12 22:28 ` Rajat Jain
2021-04-25 14:58 ` [PATCH v2 1/2] driver core: Move the "removable" attribute from USB to core Alan Stern
2021-05-11 19:22 ` Bjorn Helgaas
2021-05-11 21:36 ` Rajat Jain
2021-05-12 1:00 ` Krzysztof Wilczyński
2021-05-12 1:20 ` Rajat Jain
2021-05-12 22:27 ` Rajat Jain
2021-05-12 23:32 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jEbjRSGPdfwvegawin5_N=m-UoP+Wa99EQ-QmkusiBCg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=David.Laight@aculab.com \
--cc=bhelgaas@google.com \
--cc=dtor@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=jsbarnes@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).