From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Meng Li <li.meng@amd.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Huang Rui <ray.huang@amd.com>,
Linux PM <linux-pm@vger.kernel.org>,
Nathan Fontenot <nathan.fontenot@amd.com>,
Deepak Sharma <deepak.sharma@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Jinzhou Su <Jinzhou.Su@amd.com>, Perry Yuan <Perry.Yuan@amd.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Borislav Petkov <bp@alien8.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Add unit test module for AMD P-State driver
Date: Wed, 13 Apr 2022 17:41:44 +0200 [thread overview]
Message-ID: <CAJZ5v0jFXhfL=2TwBfzzfEdyKUwYDCxo8OKZuYtJjASKE5Oqfw@mail.gmail.com> (raw)
In-Reply-To: <20220413090510.4039589-1-li.meng@amd.com>
On Wed, Apr 13, 2022 at 11:06 AM Meng Li <li.meng@amd.com> wrote:
>
> Hi all:
>
> AMD P-State unit test(amd_pstate_testmod) is a kernel module for testing
> the functions of amd-pstate driver.
> It could import as a module to launch some test tasks.
>
> We upstream out AMD P-state driver into Linux kernel and use this unit
> test module to verify the required conditions and basic functions of
> amd-pstate before integration test.
>
> We use test module in the kselftest frameworks to implement it.
> We create amd_pstate_testmod module and tie it into kselftest.
>
> For exmaple: The test case aput_acpi_cpc is used to check whether the
> _CPC object is exist in SBIOS.
> The amd-pstate initialization will fail if the _CPC in ACPI SBIOS is
> not existed at the detected processor, so it is a necessary condition.
>
> At present, its test cases are very simple, and the corresponding test
> cases will continue to be added later to improve the test coverage.
>
> See patch series in below git repo:
> V1: https://lore.kernel.org/linux-pm/20220323071502.2674156-1-li.meng@amd.com/
>
> Changes from V1 -> V2:
> - cpufreq: amd-pstate:
> - - add a trailing of amd-pstate.h to MAINTAINER AMD PSTATE DRIVER
> - selftests: cpufreq
> - - add a wrapper shell script for the amd_pstate_testmod module
> - selftests: cpufreq:
> - - remove amd_pstate_testmod kernel module to .../cpufreq/amd_pstate_testmod
> - Documentation: amd-pstate:
> - - amd_pstate_testmod rst document is not provided at present.
>
> Thanks,
> Jasmine
>
> Meng Li (3):
> cpufreq: amd-pstate: Expose struct amd_cpudata
Please collect an ACK from Ray for this one as per MAINTAINERS and I
will leave the series to Shuah as it is selftests mostly.
Thanks!
> selftests: cpufreq: Add wapper script for test AMD P-State
> selftests: cpufreq: Add amd_pstate_testmod kernel module for testing
>
> MAINTAINERS | 1 +
> drivers/cpufreq/amd-pstate.c | 60 +---
> include/linux/amd-pstate.h | 74 +++++
> tools/testing/selftests/cpufreq/Makefile | 2 +-
> .../selftests/cpufreq/amd_pstate_testmod.sh | 4 +
> .../cpufreq/amd_pstate_testmod/Makefile | 20 ++
> .../amd_pstate_testmod/amd_pstate_testmod.c | 302 ++++++++++++++++++
> tools/testing/selftests/cpufreq/config | 1 +
> 8 files changed, 404 insertions(+), 60 deletions(-)
> create mode 100644 include/linux/amd-pstate.h
> create mode 100755 tools/testing/selftests/cpufreq/amd_pstate_testmod.sh
> create mode 100644 tools/testing/selftests/cpufreq/amd_pstate_testmod/Makefile
> create mode 100644 tools/testing/selftests/cpufreq/amd_pstate_testmod/amd_pstate_testmod.c
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-04-13 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:05 [PATCH v2 0/3] Add unit test module for AMD P-State driver Meng Li
2022-04-13 9:05 ` [PATCH 1/3] cpufreq: amd-pstate: Expose struct amd_cpudata Meng Li
2022-04-17 2:09 ` Huang Rui
2022-04-13 9:05 ` [PATCH 2/3] selftests: cpufreq: Add wapper script for test AMD P-State Meng Li
2022-04-13 19:55 ` Nathan Fontenot
2022-04-13 9:05 ` [PATCH 3/3] selftests: cpufreq: Add amd_pstate_testmod kernel module for testing Meng Li
2022-04-13 20:16 ` Nathan Fontenot
2022-04-17 14:54 ` Huang Rui
2022-04-13 15:41 ` Rafael J. Wysocki [this message]
2022-04-17 1:38 ` [PATCH v2 0/3] Add unit test module for AMD P-State driver Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jFXhfL=2TwBfzzfEdyKUwYDCxo8OKZuYtJjASKE5Oqfw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=Jinzhou.Su@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=li.meng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=nathan.fontenot@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).