From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbdLLQzD (ORCPT ); Tue, 12 Dec 2017 11:55:03 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:37467 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbdLLQzB (ORCPT ); Tue, 12 Dec 2017 11:55:01 -0500 X-Google-Smtp-Source: ACJfBovWPDAzfsK+6B5ngMz/+ZHP9G4izIwquKqBTKp6RjkBWYO4xhD5aBGM5+wCVHsLIdHuS/v+hpF1oMEmxbaLyzM= MIME-Version: 1.0 In-Reply-To: <1513086342-3581-1-git-send-email-shrikant.maurya@techveda.org> References: <1513086342-3581-1-git-send-email-shrikant.maurya@techveda.org> From: "Rafael J. Wysocki" Date: Tue, 12 Dec 2017 17:55:00 +0100 X-Google-Sender-Auth: aMICbgYj2i4nlp6HRPvvvKfbmKU Message-ID: Subject: Re: [PATCH] drivers: base: power: Fix GFP_KERNEL in spinlock context To: shrikant.maurya@techveda.org Cc: "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Linux PM , Linux Kernel Mailing List , sunil.m@techveda.org, karthik@techveda.org, raghu@techveda.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2017 at 2:45 PM, wrote: > From: Shrikant Maurya > > As reported by Jia-Ju Bai (https://lkml.org/lkml/2017/12/11/872): > API's are using GFP_KERNEL to allocate memory which may sleep. > > To ensure atomicity such allocations must be avoided in critical > sections under spinlock. That's right. Which is why wakeup_source_create() should never be called under a spinlock. Are you aware of any place that happens in the mainline kernel? Thanks, Rafael