From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B80C3F2CD for ; Sun, 1 Mar 2020 21:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D5C5206CC for ; Sun, 1 Mar 2020 21:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583097800; bh=tWzpwSs3+T0TmgH38aKlT6EJLNraULipQkjfIIXFGEk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=yyALbnudFwAxG3KaKNqGFL59xzXP2mJov3fY9P66FV70F+rs28GBeVQdg6SpoDeIW hSQ8nFUs7qf52zuooOrI15XE94xV5DLwOkdPk7OQtIpCQAEVIqGVgjwwpzE9d+IyJq 5wGo09dVEVkitbWABfqoyirto6NJyhTTwNBPnRdo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgCAVXT (ORCPT ); Sun, 1 Mar 2020 16:23:19 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:44308 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgCAVXS (ORCPT ); Sun, 1 Mar 2020 16:23:18 -0500 Received: by mail-oi1-f193.google.com with SMTP id d62so8357570oia.11; Sun, 01 Mar 2020 13:23:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g90Jsy31XrppfqU2qdwvAKX4AQi5k+8zFJzl7y6CTO8=; b=hpqnu07zFA3Uke2RMN5J3KIoXQHeR5VtJcuge9sJYzpib0EgJmQMvA1lYUmqbK3FBI kKif4O9kcKlAVsv3MOzdHiFQzi19/ON+4JYm3DBUD8gaSiNxvOoWYCc/ayZtkmlfnqAm 2GCHO9qnKohEpFb2Ez0H8s8oaaRhVNc4aA9ZvtFfk3fVno69l2JASjpAoVuIbS42eydb wdBJT2fRMOWudKEMhfE3eSKqbLufyhoNbhkzq+PlAxToZMCfmGrg0gFpw6eHhb/OYgEL Ewgc5+5rdfhDxhyVmvEWTcwppcYzSDvHmQevv2HXXlfWft9q37ydH2i3gQYOpmtFQ59A 1Fgw== X-Gm-Message-State: APjAAAXRDXWlXJV0uhoX9vtg7QM5r727EEzrod6M2vG4sPmIFZhRTmdn HaCypxfZ+FCvoqfwVQghd9u+/S2Yhy7Q1KswxhM= X-Google-Smtp-Source: APXvYqzcg028OV6MOcUNz9riYTwG1HmNKNDoar9+w8ggrxYqXP3bcp5HMo1s3kEuWmpCdQOlzFaMz3PPlEVbBkxC6jQ= X-Received: by 2002:aca:ebcf:: with SMTP id j198mr8056491oih.115.1583097798061; Sun, 01 Mar 2020 13:23:18 -0800 (PST) MIME-Version: 1.0 References: <20200228174630.8989-1-madhuparnabhowmik10@gmail.com> In-Reply-To: From: "Rafael J. Wysocki" Date: Sun, 1 Mar 2020 22:23:07 +0100 Message-ID: Subject: Re: [PATCH 1/2] drivers: base: power: main: Use built-in RCU list checking To: Joel Fernandes Cc: "Rafael J. Wysocki" , madhuparnabhowmik10@gmail.com, "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Linux PM , Linux Kernel Mailing List , frextrite@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, paulmck@kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 1, 2020 at 9:53 PM wrote: > > > > On March 1, 2020 3:12:53 PM EST, "Rafael J. Wysocki" wrote: > >On Fri, Feb 28, 2020 at 6:47 PM wrote: > >> > >> From: Madhuparna Bhowmik > >> > >> This patch passes the cond argument to list_for_each_entry_rcu() > >> to fix the following false-positive lockdep warnings: > >> > >> [ 330.302784] ============================= > >> [ 330.302789] WARNING: suspicious RCU usage > >> [ 330.302796] 5.6.0-rc1+ #5 Not tainted > >> [ 330.302801] ----------------------------- > >> [ 330.302808] drivers/base/power/main.c:326 RCU-list traversed in > >non-reader section!! > >> > >> [ 330.303303] ============================= > >> [ 330.303307] WARNING: suspicious RCU usage > >> [ 330.303311] 5.6.0-rc1+ #5 Not tainted > >> [ 330.303315] ----------------------------- > >> [ 330.303319] drivers/base/power/main.c:1698 RCU-list traversed in > >non-reader section!! > >> > >> [ 331.934969] ============================= > >> [ 331.934971] WARNING: suspicious RCU usage > >> [ 331.934973] 5.6.0-rc1+ #5 Not tainted > >> [ 331.934975] ----------------------------- > >> [ 331.934977] drivers/base/power/main.c:1238 RCU-list traversed in > >non-reader section!! > >> > >> [ 332.467772] WARNING: suspicious RCU usage > >> [ 332.467775] 5.6.0-rc1+ #5 Not tainted > >> [ 332.467775] ----------------------------- > >> [ 332.467778] drivers/base/power/main.c:269 RCU-list traversed in > >non-reader section!! > > > >I don't see these warnings in the kernels run locally here. > > > >What do you do to get them? > > > >Joel, any comments here? > > You have to enable lockdep in your config. Does your setup have that? CONFIG_LOCK_DEBUGGING_SUPPORT=y CONFIG_PROVE_LOCKING=y CONFIG_DEBUG_SPINLOCK=y CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_LOCKDEP=y Anything else?