From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62E3C41514 for ; Fri, 9 Aug 2019 08:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4D262189D for ; Fri, 9 Aug 2019 08:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565337655; bh=zmD4rgreMnW2tmYo8AEpn/l744fJXXyYWDyfqaFDXS8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=kREVaJBA8Cxx0jObSAxqQQf1C/fmkHLgO5p4B7c1SP31AzR6bNmxn0dY4gc9o3reA zqZRMwQaaFMkOWt7XIENLIoYlD6H+chGILc6+B6ewk3bnlGEteSVYSUFtsG0sayzZg nggSyCY+xOu3J5aweGmiYziVzz8dYS6RSyb/u6gY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405711AbfHIIAx (ORCPT ); Fri, 9 Aug 2019 04:00:53 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:38681 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728823AbfHIIAw (ORCPT ); Fri, 9 Aug 2019 04:00:52 -0400 Received: by mail-ot1-f65.google.com with SMTP id d17so129502271oth.5; Fri, 09 Aug 2019 01:00:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MvmuOMegXGyoZoAVbYJEjhJdJHb/HkNFFGNS7y3IwZI=; b=tISWeRqNfle2pMQquYdjr3Ccb1Cs3sBx56sfI0jfJq641B+jYE6G/WhPIA7PeN7FMX /phxRK4vIhGQxBFwnRxtFILDnDzjUUNZfHajDAwDUUBbIulkhpmAON5uyvH1JXqtXP5i Fbc92PcC6w4RgfA6VteFj4kZGR6DrEeMWQtHZZJYQcfVm4wjHFzEwIBtt5Tc8v04NSjK 5uSWRrN8deJ74d5cvf9Sz44tDPZD7W1GX3U3YqYlzM29WkPHvHgJIAprxTa4JGycTpme VTCwN7LdyfoIvD7BXd08MjgxlWc6d3aHwUm7Y61KMkVQWsSjp84vBzVX8UNhrtlsMnmx 199A== X-Gm-Message-State: APjAAAUCNWy+Jvj3yCbLfRyNV99GMtcb/NyuZsQIDqzXSSQ4V1WXc1bm q2qJzynkFaejIfd4n2bhu1ChrElLYSrCfK9VfVE= X-Google-Smtp-Source: APXvYqybdxurf5JCgFnVgFRlNNteHx+/jN3ZkSQs93AnC48rBlzxUL09kEEXqLZe0rOCiS9V4aor+P2ybINju+sDcVs= X-Received: by 2002:a9d:6b96:: with SMTP id b22mr17340509otq.262.1565337651853; Fri, 09 Aug 2019 01:00:51 -0700 (PDT) MIME-Version: 1.0 References: <4323ed84dd07474eab65699b4d007aaf@AUSX13MPC105.AMER.DELL.COM> <20190731221956.GB15795@localhost.localdomain> <2184247.yL3mcj2FRQ@kreacher> <1618955.HVa0YQSOW5@kreacher> <20190809045058.GE7302@google.com> In-Reply-To: <20190809045058.GE7302@google.com> From: "Rafael J. Wysocki" Date: Fri, 9 Aug 2019 10:00:41 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] PCI: PCIe: ASPM: Introduce pcie_aspm_enabled() To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , linux-nvme , Keith Busch , Mario Limonciello , Kai-Heng Feng , Keith Busch , Christoph Hellwig , Sagi Grimberg , Linux PM , Linux Kernel Mailing List , Rajat Jain , Linux PCI Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 9, 2019 at 6:51 AM Bjorn Helgaas wrote: > > s|PCI: PCIe: ASPM: Introduce pcie_aspm_enabled()|PCI/ASPM: Add pcie_aspm_enabled()| Will change. > > to match previous history. > > On Thu, Aug 08, 2019 at 11:55:07PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Add a function checking whether or not PCIe ASPM has been enabled for > > a given device. > > > > It will be used by the NVMe driver to decide how to handle the > > device during system suspend. > > > > Signed-off-by: Rafael J. Wysocki > > Acked-by: Bjorn Helgaas Thanks! > > --- > > > > v2 -> v3: > > * Make the new function return bool. > > * Change its name back to pcie_aspm_enabled(). > > * Fix kerneldoc comment formatting. > > > > -> v2: > > * Move the PCI/PCIe ASPM changes to a separate patch. > > * Add the _mask suffix to the new function name. > > * Add EXPORT_SYMBOL_GPL() to the new function. > > * Avoid adding an unnecessary blank line. > > > > --- > > drivers/pci/pcie/aspm.c | 20 ++++++++++++++++++++ > > include/linux/pci.h | 3 +++ > > 2 files changed, 23 insertions(+) > > > > Index: linux-pm/drivers/pci/pcie/aspm.c > > =================================================================== > > --- linux-pm.orig/drivers/pci/pcie/aspm.c > > +++ linux-pm/drivers/pci/pcie/aspm.c > > @@ -1170,6 +1170,26 @@ static int pcie_aspm_get_policy(char *bu > > module_param_call(policy, pcie_aspm_set_policy, pcie_aspm_get_policy, > > NULL, 0644); > > > > +/** > > + * pcie_aspm_enabled - Check if PCIe ASPM has been enabled for a device. > > + * @pci_device: Target device. > > + */ > > +bool pcie_aspm_enabled(struct pci_dev *pci_device) > > The typical name in this file is "pdev". OK, will change. > > +{ > > + struct pci_dev *bridge = pci_upstream_bridge(pci_device); > > + bool ret; > > + > > + if (!bridge) > > + return false; > > + > > + mutex_lock(&aspm_lock); > > + ret = bridge->link_state ? !!bridge->link_state->aspm_enabled : false; > > + mutex_unlock(&aspm_lock); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(pcie_aspm_enabled); > > + > > #ifdef CONFIG_PCIEASPM_DEBUG > > static ssize_t link_state_show(struct device *dev, > > struct device_attribute *attr, > > Index: linux-pm/include/linux/pci.h > > =================================================================== > > --- linux-pm.orig/include/linux/pci.h > > +++ linux-pm/include/linux/pci.h > > @@ -1567,8 +1567,11 @@ extern bool pcie_ports_native; > > > > #ifdef CONFIG_PCIEASPM > > bool pcie_aspm_support_enabled(void); > > +bool pcie_aspm_enabled(struct pci_dev *pci_device); > > #else > > static inline bool pcie_aspm_support_enabled(void) { return false; } > > +static inline bool pcie_aspm_enabled(struct pci_dev *pci_device) > > +{ return false; } > > #endif > > > > #ifdef CONFIG_PCIEAER > > > > > >