From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A709AC43219 for ; Tue, 30 Apr 2019 09:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 732F92080C for ; Tue, 30 Apr 2019 09:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556617082; bh=qdi2n62mB3f8vz/g5Kf6QSOPysHMAPgmt/OH2YScPxc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=WPe9SPQZZrz0XDEGIse6bMgXBe/NNIa1y/3E0csW3ZIBXQjKi6SUhUMHJq/NXmFgz xxbi5UANYdbzXCuVtNlbOE3cg91/k6zIMD99lShjRviGg4G19IQfvDbtQKvMDEKpKu MSCdGgVQTngsi/1BfS8I4QYJdvQ86UZmL4C1TbYE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbfD3JiB (ORCPT ); Tue, 30 Apr 2019 05:38:01 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:37003 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726967AbfD3JiA (ORCPT ); Tue, 30 Apr 2019 05:38:00 -0400 Received: by mail-oi1-f194.google.com with SMTP id k6so10716474oic.4; Tue, 30 Apr 2019 02:38:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G02lSv0pt7QJfrRFGxakI+OyJ7BUeTOYjdVwMTEfN0s=; b=IwGxDbHSz3HG7DhfvwUV8hbenZPbye7Ft+YbVBT+Wnn2jbUsXS5xfIRITESazCg34Y CEvoaCel8XUMAxFFjU/UKqxfsxDw0G64eez/GqSd+PGY72nh30MIJ16gYgEZBZwjLRz4 7ggmI5XyiWySfnRmk1o46soyNiJZADyp0ZZuL4Zf1hVXt+65aloyB7d2LQdGholoU1cd 27ZQ9TSJzDNuH9Xt25Y1nZe3iZZl0hzdYt4jUH9atiXvTGRYPntcmbYM8wKmS9N3v4CB NxTBNrzjFoZPahAdhG2NcfpUFxhqMZNOwV64DFGryqCl1YOycABoDqeM0anGvK+eVy+a KZkw== X-Gm-Message-State: APjAAAXTaYQgyUA3hC42LgcMRIwTjHGploZztyp8RGGFRwrTVoySpCSn 57sJvBwaBlfSs25kr6Jp5oqkc0VsrG/TB10RkOM= X-Google-Smtp-Source: APXvYqzKBkegFmwRtDoxQY/Q7yBPBpwIw2wXGmR//XNH8g3oQwIbzhqrBpmSszrOZgg8Sea+4dv3dPeMh+VxcnqdKz8= X-Received: by 2002:aca:ba82:: with SMTP id k124mr2539209oif.110.1556617079642; Tue, 30 Apr 2019 02:37:59 -0700 (PDT) MIME-Version: 1.0 References: <20190430090021.GF26516@lahna.fi.intel.com> In-Reply-To: <20190430090021.GF26516@lahna.fi.intel.com> From: "Rafael J. Wysocki" Date: Tue, 30 Apr 2019 11:37:48 +0200 Message-ID: Subject: Re: [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt) To: Mika Westerberg , "Schmauss, Erik" Cc: mh@mike.franken.de, Lukas Wunner , Takashi Iwai , Bjorn Helgaas , ckellner@redhat.com, Greg Kroah-Hartman , Jiri Slaby , Linux Kernel Mailing List , "Rafael J. Wysocki" , Furquan Shaikh , ACPI Devel Maling List , Robert Moore Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 11:00 AM Mika Westerberg wrote: > > +Rafael, Furquan and linux-acpi > > (The original thread is here https://lore.kernel.org/lkml/s5hy33siofw.wl-tiwai@suse.de/T/#u) > > On Tue, Apr 30, 2019 at 10:39:00AM +0200, Michael Hirmke wrote: > > Hi Takashi, > > > > [...] > > >>> I also have XPS 9370 but not that particular dock. I will check tomorrow > > >>> if I can reproduce it as well. > > >> > > >> There aren't too many changes between 5.0.7 and 5.0.8 that touch > > >> PCI/ACPI. This is just a shot in the dark but could you try to revert: > > >> > > >> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gi > > >> t/commit/?h=linux-5.0.y&id=da6a87fb0ad43ae811519d2e0aa325c7f792b13a > > >> > > >> and see if it makes any difference? > > > > >OK, I'm building a test kernel package with the revert in OBS > > >home:tiwai:bsc1133486 repo. A new kernel will be > > >kernel-default-5.0.10-*g8edeab8: > > > http://download.opensuse.org/repositories/home:/tiwai:/bsc1133486/standard/ > > > > >Michael, once when the new kernel is ready, please give it a try. > > > > as far as I can see, state is back to normal with this kernel. > > No more error messages or crashing modules and all devices seem to work > > as expected. > > Only thing is, that the external devices connected to the Thunderbolt > > dock are coming up a little bit slower than with 5.0.7 - but this is > > nothing, I'd worry about. > > Thanks for testing. > > Rafael, it seems that commit c8b1917c8987 ("ACPICA: Clear status of GPEs > before enabling them") causes problem with Thunderbolt controllers if > you boot with device (dock) connected. > > I think the reason is the same that got fixed in v4.14 with commit > ecc1165b8b74 ("ACPICA: Dispatch active GPEs at init time") which the > above commit essentially undoes if I understand it correctly. OK, I'll queue up a revert of that one then, thanks! Erik, I think that commit c8b1917c8987 has been picked up by the upstream ACPICA already. If I'm not mistaken, it needs to be reverted from there as well.