From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>, Kyle Meyer <kyle.meyer@hpe.com>
Cc: Takashi Iwai <tiwai@suse.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur
Date: Mon, 7 Jun 2021 13:09:00 +0200 [thread overview]
Message-ID: <CAJZ5v0jgH64Kbi12+tYbq384z5qEOKB68VELwtq28oiF1DjxkA@mail.gmail.com> (raw)
In-Reply-To: <20210607072637.b5mwcalab7y2vikx@vireshk-i7>
On Mon, Jun 7, 2021 at 9:26 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 07-06-21, 09:13, Takashi Iwai wrote:
> > The missing key information is that it's a fix for the recent change
> > for 5.14, i.e.
> > Fixes: c1d6d2fd2f64 ("cpufreq: acpi-cpufreq: Skip initialization if cpufreq driver is present")
> >
> > The change made the module left even if it exits before registering
> > the cpufreq driver object.
>
> The original patch looks buggy to me, I was never able to review it :(
>
> I have replied on the original thread instead.
Well, thanks, but that confused me a bit.
Given the above, I'm going to drop the original patch.
Kyle, please reconsider this approach.
prev parent reply other threads:[~2021-06-07 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 17:05 [PATCH] acpi-cpufreq: Skip cleanup if initialization didn't occur kyle.meyer
2021-06-07 3:25 ` Viresh Kumar
2021-06-07 7:13 ` Takashi Iwai
2021-06-07 7:26 ` Viresh Kumar
2021-06-07 11:09 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jgH64Kbi12+tYbq384z5qEOKB68VELwtq28oiF1DjxkA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=kyle.meyer@hpe.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).