From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Sinan Kaya <okaya@kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
"moderated list:INTEL ASoC DRIVERS" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.com>,
Jie Yang <yang.jie@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Date: Wed, 2 Jan 2019 23:01:43 +0100 [thread overview]
Message-ID: <CAJZ5v0jniuqiLVnB3ufkAKY2nT4H6OJG-wWrL7GsaK5dAJ6ybA@mail.gmail.com> (raw)
In-Reply-To: <57ed1d94-7f89-20e8-3289-7ef7efd18c20@linux.intel.com>
On Wed, Jan 2, 2019 at 9:33 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
> I have three opens with this ACPI/PCI change
>
> 1. the baseline change fails on my cross-compilation checks, see below
> the result of the attached script (simplification of the one I use to
> avoid 0day reports).
What baseline change?
That failure is not related to PCI if I'm not missing anything.
> 2. there are different patterns to express the dependency on PCI e.g.
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> depends on MMC_SDHCI && ACPI
> - select IOSF_MBI if X86
> + select IOSF_MBI if (X86 && PCI)
>
> but
>
> config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> default ACPI
> - depends on X86 && ACPI
> + depends on X86 && ACPI && PCI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
>
> IOSF is only needed for Baytrail-CR detection, and the code will compile
> fine without it, so maybe it'd be a better model if you used the
> following diff?
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 2fd1b61e8331..68af0ea5c96c 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -95,7 +95,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> select SND_SST_IPC_ACPI
> select SND_SST_ATOM_HIFI2_PLATFORM
> select SND_SOC_ACPI_INTEL_MATCH
> - select IOSF_MBI
> + select IOSF_MBI if PCI
Well, does it actually make sense to ever set
SND_SST_ATOM_HIFI2_PLATFORM_ACPI without PCI?
> 3. All the Intel machine drivers depend on X86_INTEL_LPSS which depends
> on PCI. But for Baytrail/Haswell/Broadwell we have only a dependency on
> ACPI, so we expose drivers that can be selected but fail on probe since
> there are no machine drivers. I am not sure if we want to be strict and
> only expose meaningful configurations, or allow for more compilations
> tests and corner cases?
I would only expose meaningful configurations to start with and then
*maybe* relax that going forward as long as the benefit is worth it.
Cheers,
Rafael
next prev parent reply other threads:[~2019-01-02 22:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190102181038.4418-1-okaya@kernel.org>
2019-01-02 18:10 ` [PATCH v5 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: " Sinan Kaya
2019-01-07 11:12 ` Rafael J. Wysocki
[not found] ` <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
2019-01-07 14:17 ` Bartlomiej Zolnierkiewicz
2019-01-07 15:41 ` Jens Axboe
2019-01-07 17:52 ` Rafael J. Wysocki
2019-01-02 18:10 ` [PATCH v5 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 04/11] platform/x86: intel_ips: " Sinan Kaya
2019-01-04 14:13 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2019-01-04 14:20 ` Andy Shevchenko
2019-01-04 15:07 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 06/11] platform/x86: apple-gmux: " Sinan Kaya
2019-01-02 18:45 ` Lukas Wunner
2019-01-04 14:12 ` Andy Shevchenko
2019-01-04 14:20 ` Andy Shevchenko
2019-01-02 18:10 ` [PATCH v5 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 08/11] ASoC: Intel: atom: " Sinan Kaya
2019-01-02 20:33 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-02 22:01 ` Rafael J. Wysocki [this message]
2019-01-02 22:09 ` Sinan Kaya
2019-01-02 22:50 ` Pierre-Louis Bossart
2019-01-02 22:58 ` Sinan Kaya
2019-01-02 23:50 ` Pierre-Louis Bossart
2019-01-03 3:28 ` Sinan Kaya
2019-01-03 4:08 ` Chandan Rajendra
2019-01-03 9:52 ` Rafael J. Wysocki
2019-01-03 16:28 ` Pierre-Louis Bossart
2019-01-04 10:55 ` Chandan Rajendra
2019-01-03 12:33 ` Mark Brown
2019-01-03 12:43 ` Rafael J. Wysocki
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: " Sinan Kaya
2019-01-03 14:49 ` Adrian Hunter
2019-01-03 14:57 ` Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 10/11] x86/intel/lpss: " Sinan Kaya
2019-01-11 18:36 ` [tip:x86/urgent] " tip-bot for Sinan Kaya
2019-01-02 18:10 ` [PATCH v5 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jniuqiLVnB3ufkAKY2nT4H6OJG-wWrL7GsaK5dAJ6ybA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).