From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] PM / wakeup: Add callback for wake-up change notification
Date: Wed, 20 Jun 2018 14:15:38 +0200 [thread overview]
Message-ID: <CAJZ5v0ju3F7qWxMUDuCyWBzFQGyrmxVo90yytFbKnCmENvRuew@mail.gmail.com> (raw)
In-Reply-To: <20180620103558.GA6242@sirena.org.uk>
On Wed, Jun 20, 2018 at 12:35 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 20, 2018 at 10:02:41AM +0200, Rafael J. Wysocki wrote:
>> On Tuesday, June 19, 2018 5:22:06 PM CEST Geert Uytterhoeven wrote:
>> > On Tue, Jun 19, 2018 at 4:48 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>> > > On Tue, Jun 19, 2018 at 3:55 PM, Geert Uytterhoeven
>
>> > In v1 (https://patchwork.kernel.org/patch/9996567/), I had a
>> > driver-specific "backup_mode" sysfs file.
>> > In v2 and later of the driver series (https://lkml.org/lkml/2018/4/18/345),
>> > I changed that to use the standard "wakeup" file in sysfs, in response to
>> > a comment from Mark Brown.
>
>> Well, I'm not convinced that this is the right approach, though.
>
> The original description of the changes made it sound like this
> controlled if the power switch would make the device resume from suspend
> or not which seems like a wakeup to me. Honestly as things are I've no
> idea what the hardware designers were thinking or how to explain what
> this stuff is doing.
>
>> > Do you still prefer a driver-specific sysfs file?
>
>> Yes, I do.
>
> The flip side of that is that either suspend and resume or poweroff are
> broken for userspace unless they know about this magic sysfs file which
> isn't great either.
But to me that isn't that much different from an RTC wake alarm, say.
Enabling it to wake up the system in general isn't sufficient, you
also need to actually set the alarm using a different interface.
next prev parent reply other threads:[~2018-06-20 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:55 [PATCH v2 0/2] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-06-19 13:55 ` [PATCH v2 1/2] PM / wakeup: Add callback for wake-up change notification Geert Uytterhoeven
2018-06-19 14:47 ` Rafael J. Wysocki
2018-06-19 15:22 ` Geert Uytterhoeven
2018-06-20 8:02 ` Rafael J. Wysocki
2018-06-20 10:35 ` Mark Brown
2018-06-20 12:15 ` Rafael J. Wysocki [this message]
2018-06-20 13:25 ` Mark Brown
2018-06-26 10:06 ` Geert Uytterhoeven
2018-06-26 10:16 ` Rafael J. Wysocki
2018-06-26 10:29 ` Geert Uytterhoeven
2018-06-26 13:55 ` Rafael J. Wysocki
2018-06-19 13:55 ` [PATCH v2 2/2] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0ju3F7qWxMUDuCyWBzFQGyrmxVo90yytFbKnCmENvRuew@mail.gmail.com \
--to=rafael@kernel.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).