From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH -next] PM: domains: fix some kernel-doc issues
Date: Tue, 8 Jun 2021 14:57:23 +0200 [thread overview]
Message-ID: <CAJZ5v0jvzRTypqYK0O+-ajMZdaHb+4uJJOdK5pEtxCsD4yDdLA@mail.gmail.com> (raw)
In-Reply-To: <20210512072515.3820032-1-yangyingliang@huawei.com>
On Wed, May 12, 2021 at 9:22 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Fix the following make W=1 kernel build warnings:
>
> drivers/base/power/domain_governor.c:259: warning: Function parameter or member 'now' not described in '_default_power_down_ok'
> drivers/base/power/domain.c:581: warning: Function parameter or member 'depth' not described in 'genpd_power_off'
> drivers/base/power/domain.c:2520: warning: Function parameter or member 'np' not described in 'of_genpd_remove_last'
> drivers/base/power/domain.c:2520: warning: Excess function parameter 'provider' description in 'of_genpd_remove_last'
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/base/power/domain.c | 3 ++-
> drivers/base/power/domain_governor.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index b6a782c31613..5695a641efd3 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -572,6 +572,7 @@ static void genpd_queue_power_off_work(struct generic_pm_domain *genpd)
> * RPM status of the releated device is in an intermediate state, not yet turned
> * into RPM_SUSPENDED. This means genpd_power_off() must allow one device to not
> * be RPM_SUSPENDED, while it tries to power off the PM domain.
> + * @depth: nesting count for lockdep.
> *
> * If all of the @genpd's devices have been suspended and all of its subdomains
> * have been powered down, remove power from @genpd.
> @@ -2505,7 +2506,7 @@ EXPORT_SYMBOL_GPL(of_genpd_remove_subdomain);
>
> /**
> * of_genpd_remove_last - Remove the last PM domain registered for a provider
> - * @provider: Pointer to device structure associated with provider
> + * @np: Pointer to device node associated with provider
> *
> * Find the last PM domain that was added by a particular provider and
> * remove this PM domain from the list of PM domains. The provider is
> diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
> index c6c218758f0b..cd08c5885190 100644
> --- a/drivers/base/power/domain_governor.c
> +++ b/drivers/base/power/domain_governor.c
> @@ -252,6 +252,7 @@ static bool __default_power_down_ok(struct dev_pm_domain *pd,
> /**
> * _default_power_down_ok - Default generic PM domain power off governor routine.
> * @pd: PM domain to check.
> + * @now: current ktime.
> *
> * This routine must be executed under the PM domain's lock.
> */
> --
Applied as 5.14 material, thanks!
prev parent reply other threads:[~2021-06-08 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 7:25 [PATCH -next] PM: domains: fix some kernel-doc issues Yang Yingliang
2021-06-08 12:57 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jvzRTypqYK0O+-ajMZdaHb+4uJJOdK5pEtxCsD4yDdLA@mail.gmail.com \
--to=rafael@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).