From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C183FC43334 for ; Fri, 8 Jul 2022 11:29:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237594AbiGHL3W (ORCPT ); Fri, 8 Jul 2022 07:29:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237336AbiGHL3Q (ORCPT ); Fri, 8 Jul 2022 07:29:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CCC72951C9 for ; Fri, 8 Jul 2022 04:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657279751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQ8hI7tAToAaGENhoelGGeUPhfdGj6ZA32YUdh4TI7g=; b=erkHckSpTKhpr3t0qW94EHRpsmCPPtbrmrsqXpiBthAe4QP/p3E4q/XPrjVYVwx130f7Rc 2VknINL9mefRysoZWsb1ApWNaGImjNDkdsCSGhITzy3Q68dTfK1w4pRhKg4+Pngo1l/6ql MWysHNtCuLjaX2PykKxVSPfTH9uhBHY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-aZ1XpYjsONC48qv2oilMGA-1; Fri, 08 Jul 2022 07:29:04 -0400 X-MC-Unique: aZ1XpYjsONC48qv2oilMGA-1 Received: by mail-qt1-f197.google.com with SMTP id u2-20020ac80502000000b002f94701339eso18266332qtg.13 for ; Fri, 08 Jul 2022 04:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pQ8hI7tAToAaGENhoelGGeUPhfdGj6ZA32YUdh4TI7g=; b=E0cE7pDAlx5Zbkt9XnahNTA43B5xYYv4ch3fAf91HOFhxn7JVJi0Kp4G9IWxicua4p ytfQq3GX9souZLF+nBppHM0Yd1JmRHTFlk33rYHJg4kubFr9FPFoDMWvCOEUhvxNL6u9 dqplV4pIHXksGnaLxOpKu97vFEwTQFSYWLYoLBEMbTq1aSSc0VJJaveZRtqstdBaak55 MjRDzPfJFQSzRD0WAG2PVCpG8KYZVeotHNkFwNGQi0rhVQhsFp0CY5gZnMaexghCHZHO MZKBdU3jP7FWREPTkwi+yIhO7TML1dbaP1sJzLHBThBQJXyjD1OdK+9GrH1zi8nw8C1w ZFKg== X-Gm-Message-State: AJIora+q18+uMxL3/x+SOHGKvVKEvnbHfD5wIfaoHh4vZCiMQh7EQ21I qAWABA2oh204JvFdaGMx+/vWbc/HlL0YA2BO006gQLj4X6LylrUwLrimShzZ96j7Yqy+hRLAl0f Xf4y6B0J+3bz3ZGSHmeeSAzItul2VgqxOkR1xzdFb X-Received: by 2002:ac8:5dca:0:b0:31e:85b8:8a18 with SMTP id e10-20020ac85dca000000b0031e85b88a18mr2366797qtx.370.1657279744180; Fri, 08 Jul 2022 04:29:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sentVPmK5WEA4lrN7utaqjkf+t27q8DqhRdkX0cZZhMbHLJdy+uMh1/O3NgdOS4+jT1HeWza8vKer/xm5M1KI= X-Received: by 2002:ac8:5dca:0:b0:31e:85b8:8a18 with SMTP id e10-20020ac85dca000000b0031e85b88a18mr2366771qtx.370.1657279743969; Fri, 08 Jul 2022 04:29:03 -0700 (PDT) MIME-Version: 1.0 References: <20220623160738.632852-1-eperezma@redhat.com> <20220623160738.632852-2-eperezma@redhat.com> <20220628133955.sj32sfounu4byggl@sgarzare-redhat> In-Reply-To: <20220628133955.sj32sfounu4byggl@sgarzare-redhat> From: Eugenio Perez Martin Date: Fri, 8 Jul 2022 13:28:27 +0200 Message-ID: Subject: Re: [PATCH v6 1/4] vdpa: Add suspend operation To: Stefano Garzarella Cc: netdev , Jason Wang , linux-kernel , virtualization , kvm list , "Michael S. Tsirkin" , Parav Pandit , Christophe JAILLET , Cindy Lu , "Kamde, Tanuj" , Si-Wei Liu , "Uminski, Piotr" , habetsm.xilinx@gmail.com, "Dawar, Gautam" , Pablo Cascon Katchadourian , Zhu Lingshan , Laurent Vivier , Longpeng , Dinan Gunawardena , Martin Petrus Hubertus Habets , Martin Porter , Eli Cohen , ecree.xilinx@gmail.com, Wu Zongyong , Dan Carpenter , Harpreet Singh Anand , Xie Yongji , Zhang Min Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 3:40 PM Stefano Garzarella wr= ote: > > On Thu, Jun 23, 2022 at 06:07:35PM +0200, Eugenio P=C3=A9rez wrote: > >This operation is optional: It it's not implemented, backend feature bit > >will not be exposed. > > > >Signed-off-by: Eugenio P=C3=A9rez > >--- > > include/linux/vdpa.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > >diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > >index 7b4a13d3bd91..d282f464d2f1 100644 > >--- a/include/linux/vdpa.h > >+++ b/include/linux/vdpa.h > >@@ -218,6 +218,9 @@ struct vdpa_map_file { > > * @reset: Reset device > > * @vdev: vdpa device > > * Returns integer: success (0) or error (< = 0) > >+ * @suspend: Suspend or resume the device (optional) > ^ > IIUC we removed the resume operation (that should be done with reset), > so should we update this documentation? > Totally, I forgot to update the doc. I'll send a new version with that. Thanks! > Thanks, > Stefano > > >+ * @vdev: vdpa device > >+ * Returns integer: success (0) or error (< = 0) > > * @get_config_size: Get the size of the configuration space i= ncludes > > * fields that are conditional on feature bi= ts. > > * @vdev: vdpa device > >@@ -319,6 +322,7 @@ struct vdpa_config_ops { > > u8 (*get_status)(struct vdpa_device *vdev); > > void (*set_status)(struct vdpa_device *vdev, u8 status); > > int (*reset)(struct vdpa_device *vdev); > >+ int (*suspend)(struct vdpa_device *vdev); > > size_t (*get_config_size)(struct vdpa_device *vdev); > > void (*get_config)(struct vdpa_device *vdev, unsigned int offset, > > void *buf, unsigned int len); > >-- > >2.31.1 > > >